Xpra: Ticket #1044: python-lzo 2.09 for win32

I've already updated my build system, please update yours and fix / verify the build instructions:

build lzo-2.09 using mingw
copy lzo-2.09\src\.libs\liblzo2.a to the root directory lzo-2.09 so it can be found more easily

unpack python-lzo and patch it (I placed the source in E:\lzo):

--- setup.py
+++ setup.py
@@ -20,13 +20,14 @@
     # Windows users have to configure the LZO_DIR path parameter to match
     # their LZO source installation.  The path set here is just an example
     # and thus unlikely to match your installation.
-    LZO_DIR = r"c:\src\lzo-1.08"
+    LZO_DIR = r"E:\lzo-2.09"
     if not os.path.exists(LZO_DIR):
         raise Exception("please set LZO_DIR to where the lzo source lives")
     include_dirs.append(os.path.join(LZO_DIR, "include"))
-    extra_objects.append(os.path.join(LZO_DIR, "lzo.lib"))
+    include_dirs.append(os.path.join(LZO_DIR, "include", "lzo"))
+    extra_objects.append(os.path.join(LZO_DIR, "liblzo2.a"))
 else:
     libraries = ["lzo2"]
     include_dirs.append("/usr/include/lzo")
     ##library_dirs.append("/usr/local/lib")

run C:\Python27\Python.exe setup.py install

Wed, 02 Dec 2015 20:17:46 GMT - Smo: owner changed

owner changed from Smo to Antoine Martin

These instructions worked fine for me for building and installing but i'm having this issue importing this module in python

C:\src\python-lzo-1.08>python
Python 2.7.10 (default, May 23 2015, 09:40:32) [MSC v.1500 32 bit (Intel)] on wi
n32
Type "help", "copyright", "credits" or "license" for more information.
>>> import lzo
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ImportError: DLL load failed: %1 is not a valid Win32 application.

Any ideas?

Thu, 03 Dec 2015 02:49:36 GMT - Antoine Martin: owner, description changed

owner changed from Antoine Martin to Smo
description modified (diff)

First, you should be doing this with python-lzo-1.09 not 1.08.

DLL load issued can usually be investigated with depends.exe

Thu, 03 Dec 2015 22:57:08 GMT - Smo: status changed; resolution set

status changed from new to closed
resolution set to fixed

Used python-lzo-1.09 and now it imports no problem.

Instructions work.

Thu, 21 Jan 2016 01:20:20 GMT - Antoine Martin:

@smo: python-lzo 1.10 is out: https://pypi.python.org/pypi/python-lzo/ (straightforward rebuild, r11693 + r11700 fixup adds it to the osx moduleset)

Thu, 21 Jan 2016 19:36:18 GMT - Antoine Martin:

Note: the 1.10 package shows up as 1.09... see https://github.com/jd-boyd/python-lzo/issues/13

Mon, 25 Jan 2016 16:21:59 GMT - Antoine Martin:

The bug has been fixed: https://pypi.python.org/pypi/python-lzo/1.11

Mon, 25 Jan 2016 21:49:44 GMT - Antoine Martin:

Applied to the jhbuild moduleset in r11754, submitted upstream: https://github.com/jd-boyd/python-lzo/issues/14.

win32 still needs doing by hand..

Tue, 29 May 2018 05:43:09 GMT - Antoine Martin:

Update to 1.12 in r19509 for macos, win32 still done by hand...

Sat, 04 Aug 2018 18:52:39 GMT - totaamwin32: attachment set

attachment set to lzo.patch

for building lzo 1.12 with mingw paths

Sat, 04 Aug 2018 18:53:35 GMT - totaamwin32:

With the patch above:

LZO_DIR=/mingw64 python3 ./setup.py build

Fri, 01 May 2020 10:58:16 GMT - Antoine Martin:

Created a pull request for mingw: add python-lzo.

Wed, 13 May 2020 14:25:26 GMT - Antoine Martin:

The pull request has been merged, now we can just install it via pacman: r26342.

Sat, 23 Jan 2021 05:13:22 GMT - migration script:

this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/1044