Xpra: Ticket #1064: libwebp 0.5.0 is broken - picture is all black!

r11491 added it, and I didn't test it well enough...

Tue, 29 Dec 2015 16:39:04 GMT - Antoine Martin: status, description changed

It's all very confusing. One of the problems is that I forgot that we can also get webp encoded and decoded via python-pillow.

And it also works fine without opengl enabled (No idea why that is. buffer re-use? how?)... which explains why I didn't see the problem during testing on virtual machines (most of which don't have opengl acceleration since the driver is blacklisted).

I think this may actually be a library conflict issue between python-pillow and dec_webp, both compiled against different versions of libwebp. If that's the case, we're lucky to have avoided problems until now! (and this only triggered now because of the ABI bump)

We don't want to start shipping a modified python-pillow (I'm not even sure how that would work wrt paths). We do ship a recent enough version of pillow, so maybe we should just drop libwebp-xpra, enc_webp and dec_webp? Are the features comparable? (in particular zerocopy uploads..)

Note: this is not a problem on OSX where we build everything against our chosen version of libwebp.

Sat, 06 Feb 2016 06:07:13 GMT - Antoine Martin:

r11857 disables the webp module (we can still do webp via pillow) for all platforms except OSX (where we already build pillow against the same version of webp, so the problem should not be present there - as long as we rebuild pillow after updating webp..) r11858 applies this change to all supported branches.

The plan:

This gives us more time to think of a better way to handle this..

Sun, 07 Feb 2016 08:18:23 GMT - Antoine Martin:

As of r11879 (r11882 for older branches), we only build the cython webp codec against the system libwebp version 0.4 or later. This condition is only guaranteed on Fedora and OSX. win32 may be OK, but I chose not to take the risk since this is a manual process that can easily break. The RPM package dependency on libwebp is removed for all but Fedora. Only stable updates to do now... prepared in r11883.

Mon, 08 Feb 2016 23:15:56 GMT - Antoine Martin: status changed; resolution set

0.14.x released with this change and a mention in the release notes: http://lists.devloop.org.uk/pipermail/shifter-users/2016-February/001476.html Same for 0.16.x: http://lists.devloop.org.uk/pipermail/shifter-users/2016-February/001477.html

Closing for now, will re-open if we encounter black rendering with webp anywhere...

Sat, 23 Jan 2021 05:13:56 GMT - migration script:

this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/1064