xpra icon
Bug tracker and wiki

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#1068 closed defect (fixed)

xpra prevents shutdown on osx

Reported by: Antoine Martin Owned by: alas
Priority: major Milestone: 0.17
Component: platforms Version: trunk
Keywords: osx Cc:

Description

If you try to shutdown your computer with xpra connected, the system will complain that xpra blocked the shutdown.

That's because we intercept NSApplicationBlockTermination and return True.
I think we should use NSApplicationWillTerminate instead.

See this discussion on the gtk-osx mailing list: https://mail.gnome.org/archives/gtk-osx-users-list/2010-August/msg00027.html.

Change History (4)

comment:1 Changed 4 years ago by Antoine Martin

Owner: changed from Antoine Martin to alas

Done in r11534. Already backported in r11537.

@afarr: it would be useful to double check that we can now shutdown the computer without getting the warning dialog, and more importantly that we still exit cleanly in all cases: from the menu, using command-Q, using the dock, using shutdown... and anything else related to "quit" which might have regressed.

comment:2 Changed 4 years ago by alas

Resolution: fixed
Status: newclosed

Testing with 0.17.0 r11535 osx client against a 0.17.0 r11580 fedora 23 server... tried every permutation I could think of to disconnect or shutdown or restart, both launching from CLI and from launcher, with no sign of any problems or errors.

Only detail that was vaguely unexpected is that, when launching with the launcher, the xpra menu lists the option of "quit xpra launcher" instead of "quit xpra"... but I'm assuming you know that.

Closing.

comment:3 Changed 4 years ago by Antoine Martin

Only detail that was vaguely unexpected is that, when launching with the launcher, the xpra menu lists the option of "quit xpra launcher" instead of "quit xpra"... but I'm assuming you know that.


I'm afraid we can't change this easily without heavily patching the gtkosx integration library..

comment:4 Changed 4 years ago by Antoine Martin

Note: maybe I am wrong about the name thing, I did see a project that was setting the appname twice: once when starting up and then again via idle_add. It seems that gtk is overriding the value on gtk.main but this may override it again.

Note: See TracTickets for help on using tickets.