xpra icon
Bug tracker and wiki

This bug tracker and wiki are being discontinued
please use https://github.com/Xpra-org/xpra instead.

Opened 6 years ago

Closed 6 years ago

Last modified 8 months ago

#1085 closed defect (fixed)

Typo in setup.py (15.X)

Reported by: J. Max Mena Owned by: Antoine Martin
Priority: blocker Milestone: 0.17
Component: core Version: 0.15.x
Keywords: Cc:


Occurs at line 655(relevant block):

    if install_dir and stripbuildroot:
        if "BUILDROOT" in dirs:
            if sys.platform.startswith("netbsd"): (BAD LINE, fixed)
                    #see: http://trac.cython.org/ticket/395
                    eifd += ["-fno-strict-aliasing"]
            if "debian" in dirs and "tmp" in dirs:
                #ugly fix for stripping the debian tmp dir:
                #ie: "???/tmp/???/tags/v0.15.x/src/debian/tmp/" -> ""
                while "tmp" in dirs:
                    dirs = dirs[dirs.index("tmp")+1:]
                #strip rpm style build root:

This line needs to be one indentation to the left. Fixing this allows builds to continue.

Change History (2)

comment:1 Changed 6 years ago by Antoine Martin

Resolution: fixed
Status: newclosed

Shocking. That block did not belong there at all, why did patch stick it here without any rejects??
More proper fix in r11650.


comment:2 Changed 8 months ago by migration script

this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/1085

Note: See TracTickets for help on using tickets.