Xpra trac archive

Xpra: Ticket #1095: support newer versions of TortoisePlink

for 2 reasons:

Downside: newer builds do not support XP

The plan: ship both versions and choose the appropriate one at runtime based on OS version detection (ie: use the old one for XP).


Sun, 24 Jan 2016 23:16:46 GMT - Antoine Martin: status changed

Mostly done in r11751 + r11753, but needs actual testing on win7 or later..

The env var XPRA_USE_NEW_PLINK can be used to force the use of the new plink (value "1") or disable it (value "0"). Otherwise we use the new plink (located in the new application subdirectory TortoisePlink) when we detect Windows version "5.x" or later.

Wed, 27 Jan 2016 22:14:11 GMT - Antoine Martin: attachment set

uses the new plink as default, only tries to old one on XP

Thu, 28 Jan 2016 01:03:36 GMT - Antoine Martin: owner, status changed

I give up with the runtime approach above, the patch did not help, win32 is no cooperating and is just not helping me figure out why this does not work. (tried hacking the %PATH%, current working directory, etc..)

r11764 makes the NEW plink the default, r11765 uses the innosetup intaller to replace the new plink with the old XP-compatible one (and also shows a warning during installation).

We still ship the old Plink.exe in a TortoisePlink-XP sub-folder, this is used by the installer hack, and could be used for switching back to the old plink - should someone wish to do that (for whatever reason). Costs us about 1MB of disk space.

The updated build files rely on extra folders for plink, you will need:

@smo: over to you to update your build systems, then please re-assign to afarr so we can check that this doesn't break anything

The new alert box can be skipped by executing the build with: 

win32\PY27_MSVC_BUILD.BAT /SILENT /SUPPRESSMSGBOXES

(the same flags are passed to the .exe installer)

Fri, 12 Feb 2016 10:45:16 GMT - Antoine Martin:

Breaks Windows Vista, see #1117.

Tue, 16 Feb 2016 17:06:54 GMT - Antoine Martin:

The correct file list can be found here: ticket:1117#comment:5.

@smo: update your build machine then please close. (feel free to test on Vista / win10 / whatever)

Thu, 31 Mar 2016 15:50:17 GMT - Smo: owner changed

I've updated to tortoisesvn 1.8 since 1.9 can't install on windows XP is this correct if so this is working.

Thu, 31 Mar 2016 15:52:17 GMT - Antoine Martin: owner changed

@smo: no, see comment:2 : A trimmed down version of the new plink from the latest tortoise svn installation (only installable on win7..). You need to grab the installation directory from a win7 system - 1.9 won't install on XP, but we need 1.9 to get the patched plink.

Fri, 15 Apr 2016 14:49:00 GMT - Antoine Martin: priority changed

Should be easy to test: XP should work as before (and show a warning during installation) and use the older plink, win7 onwards should have the newer plink installed.

Thu, 21 Apr 2016 21:02:08 GMT - Smo: owner changed

Tortoisesvn 32bit installation doesn't allow installing it on Windows7 64 bit with error message. 

You are attempting to run the 32-bit installer on a 64-bit
version of Windows. Please install the 64-bit version of
TortoiseSVN instead.

I need to get this installed on a 32 bit system but I don't have any handy.

If this works for you I suggest we just close this instead of waiting for me.

Fri, 22 Apr 2016 02:32:37 GMT - Antoine Martin: owner changed

@smo: afarr has got one. That's how I got mine.

You need this working because you may need to use the SSH transport when testing stuff.

Tue, 26 Apr 2016 23:50:56 GMT - Smo: status changed; resolution set

This is working and I get the warning on windows xp

Sat, 23 Jan 2021 05:14:50 GMT - migration script:

this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/1095