xpra icon
Bug tracker and wiki

This bug tracker and wiki are being discontinued
please use https://github.com/Xpra-org/xpra instead.


Changes between Initial Version and Version 1 of Ticket #1110, comment 8


Ignore:
Timestamp:
02/24/16 17:37:20 (5 years ago)
Author:
Antoine Martin
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #1110, comment 8

    initial v1  
    55The reason for making the change.
    66
    7 When I ran winswitch_applet in debug mode. While starting microphone from the client computer, I was getting the error, that start_sending_sound requires 7 arguments, while the arguments provided was only 6. Then I checked the definition of start_sending_sound function in wrapper.py in /usr/lib/python2.7/dist-packages/xpra/sound. It was indeed 7.
     7When I ran winswitch_applet in debug mode. While starting microphone from the client computer, I was getting the error, that start_sending_sound requires 7 arguments, while the arguments provided was only 6. Then I checked the definition of start_sending_sound function in wrapper.py in {{{/usr/lib/python2.7/dist-packages/xpra/sound}}}. It was indeed 7.
    88
    9 Then, I noticed that on the server xpra _sound_record process get's created. But, on the client it doesn't. So, I tried to scan the python code there
    10 in whole xpra folder for instances of calling start_sending_sound.
     9Then, I noticed that on the server xpra _sound_record process get's created. But, on the client it doesn't. So, I tried to scan the python code there in whole xpra folder for instances of calling start_sending_sound.
    1110
    12 I got one in /usr/lib/python2.7/dist-packages/xpra/server/source.py
     11I got one in {{{/usr/lib/python2.7/dist-packages/xpra/server/source.py}}}
    1312
    1413There, 7 arguments was being passed, and 1st argument was getting populated just before that line.
    15 
     14{{{
    1615 plugins = self.sound_properties.get("plugins") <--- This line
    1716            ss = start_sending_sound(plugins, self.sound_source_plugin, codec, volume, [codec], self.pulseaudio_server, self.pulseaudio_id)
     17}}}
    1818
    1919I copied this additional line in ui_client.py file as well in the client subdirectory, and passed plugins as the 1st argument.
     
    2323My xpra version is xpra v0.16.2.
    2424
    25 I don't know much about the specific branch and version. But, I created the diff from the svn and the directory was Xpra/tags/v0.16.x/src/xpra/client.
     25I don't know much about the specific branch and version. But, I created the diff from the svn and the directory was {{{Xpra/tags/v0.16.x/src/xpra/client}}}.