#1123 closed enhancement (fixed)
move more initialization code into server core class
Reported by: | Antoine Martin | Owned by: | Antoine Martin |
---|---|---|---|
Priority: | major | Milestone: | 3.0 |
Component: | server | Version: | trunk |
Keywords: | Cc: |
Description
This will allow us to cleanup the code somewhat and avoid issues like #1122, or at least solve them more cleanly.
The server knows if it is doing an upgrade, exit or stop - so the exit code stuff can go away too.
Change History (13)
comment:1 Changed 5 years ago by
Milestone: | 0.18 → 1.0 |
---|
comment:2 Changed 4 years ago by
Milestone: | 1.0 → future |
---|---|
Status: | new → assigned |
Too late for this release (likely to cause tricksy bugs).
comment:3 Changed 4 years ago by
This would help simplify the code used for remote ssh start: we could just start a "plain" server and let the client tell the server what it wants without using command line arguments. (better cross version compatibility)
See #1319 which does this for starting sessions via the proxy.
comment:4 Changed 3 years ago by
Milestone: | future → 3.0 |
---|
comment:7 Changed 22 months ago by
Preparatory work in r22652.
This is really hard: we can't instantiate the server class early because it (indirectly) loads GTK and X11 bindings, and for those we need to have initialized the vfb, which requires the following components to have been initialized too:
- pam
- daemonization
- logging / directories creation
- uinput virtual devices
- dbus
etc..
Even within those components, there are dependencies: uinput before pam, etc..
comment:8 Changed 22 months ago by
comment:9 Changed 22 months ago by
comment:10 Changed 22 months ago by
Updates:
- r22666 close gtk display on exit now for all types of servers (+r22667 and r22668 fixups)
- r22669 always fsync and close the pipe when using displayfd
- r22670 + r22674: move socket cleanup code to the server
- r22671 fix
--bind-ssl
socket errors on start (backport in r22672) - r22676 ssl setup moved
- r22677 fixup dbus refactoring
Still TODO:
- derive mdns data from socket info and move mdns setup code to server
- find a way to move display related stuff into the server class, delaying the actual bindings initialization until we have a display to connect to.. (hard)
comment:11 Changed 22 months ago by
comment:12 Changed 22 months ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
comment:13 Changed 6 weeks ago by
this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/1123
Milestone renamed