server.py's write_runner_shell_script() ignores XPRA_SCRIPT_BIN_DIR

[urzds]

def write_runner_shell_script(contents, overwrite=True):
    ...

in ​http://xpra.org/trac/browser/xpra/tags/v0.16.x/src/xpra/scripts/server.py#L141 calls do_get_script_bin_dir() directly, which bypasses usage of XPRA_SCRIPT_BIN_DIR.

This creates problems if the user needs to override the default location for whatever reason.

[Antoine Martin]

Fixed in r11991. Not sure why I got that wrong or if there was a reason for it. (which makes me a bit nervous to apply it to older branches as a bug fix)

@urzds: please close if this works for you.

[Antoine Martin]

Not heard back, closing.