Xpra: Ticket #1174: named pipes improvements
Follow up from #1150
- use the "socket-dir" as named pipe path (currently hard-coded to Xpra\) and use the "socket-dirs" as the list of named pipe paths we search
- shadow server crashes easily with debug logging (could be the same issue as #1149)
- non-trivial clients (ie: xpra attach) cause garbage to be received by the server
Tue, 12 Jul 2016 16:52:22 GMT - Antoine Martin: milestone changed
changed from 0.18 to 1.0
Thu, 15 Sep 2016 06:12:42 GMT - Antoine Martin: attachment set
set to named-pipes-mess-v2.patch
trying to not deadlock
Thu, 15 Sep 2016 06:13:02 GMT - Antoine Martin: status, milestone changed
changed from new to assigned
changed from 1.0 to future
r13735 is enough to be able to use "xpra info" and "xpra version" against a local win32 server (ie: "xpra shadow"), but not enough to connect as a client: when it doesn't deadlock on the named pipe, it seems to choke on the "logging" packets? (could be an encoding issue)
"xpra stop" kinda works, but again you need to run another command to get the named pipe thread to exit.
It's a mess and I really don't have time for this awful Microsoft API style.
Sun, 19 Feb 2017 06:45:47 GMT - Antoine Martin: priority, milestone changed
changed from major to critical
changed from future to 2.0
Named pipe code is currently broken by the move to ctypes (#678).
If this cannot be fixed in time, the named pipe code will have to be disabled.
Sat, 25 Feb 2017 12:02:27 GMT - Antoine Martin: attachment set
set to named-pipes-ctypes.patch
ctypes implementation that doesn't crash! (also doesn't work..)
Sun, 26 Feb 2017 08:52:05 GMT - Antoine Martin: attachment set
set to named-pipes-ctypes-v3.patch
can connect and read the packet.. but we need overlapped IO to both read and write without blocking, oh joy
Mon, 27 Feb 2017 10:04:11 GMT - Antoine Martin: owner, status changed
changed from Antoine Martin to alas
changed from assigned to new
Done in r15179. That was hard.
Some pointers that led me to the solution:
This also adds the "-d named-pipe" debug flag.
What this feature does: we can now query a running shadow server ("xpra info", "xpra list", "xpra version", "xpra stop", etc..) and even attach to it over named pipes. Follow up in #1454
@afarr: this is a FYI, feel free to close.
Tue, 20 Jun 2017 19:55:30 GMT - J. Max Mena: status changed; resolution set
changed from new to closed
set to fixed
Acknowledged, and closing.
Sat, 23 Jan 2021 05:16:59 GMT - migration script:
this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/1174