#121 closed task (fixed)
jpegquality should not be stored in protocol.py!
Reported by: | Antoine Martin | Owned by: | ahuillet |
---|---|---|---|
Priority: | major | Milestone: | 0.3 |
Component: | core | Version: | 0.1.0 |
Keywords: | Cc: |
Description (last modified by )
Why is it there?
It has nothing to do with the network layer...
I only noticed it because during testing something went wrong and the current connection got dropped, then I got this enlightening stacktrace:
Unhandled error while processing packet from peer Traceback (most recent call last): File "xpra/protocol.py", line 457, in _process_packet self._process_packet_cb(self, decoded) File "xpra/server.py", line 2072, in process_packet handler(self, proto, packet) File "xpra/server.py", line 1519, in _process_hello self._protocol.jpegquality = capabilities["jpeg"] AttributeError: 'NoneType' object has no attribute 'jpegquality'
Change History (4)
comment:1 Changed 10 years ago by
Description: | modified (diff) |
---|
comment:2 Changed 10 years ago by
comment:4 Changed 16 months ago by
this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/121
Note: See
TracTickets for help on using
tickets.
I'm not sure where it should be stored, but we should also rename it because it would be interesting to also use it to carry x264/vpx quality.