xpra icon
Bug tracker and wiki

This bug tracker and wiki are being discontinued
please use https://github.com/Xpra-org/xpra instead.


Opened 9 years ago

Closed 9 years ago

Last modified 6 months ago

#129 closed defect (fixed)

Only the first connection to server works

Reported by: Norman Rasmussen Owned by: Antoine Martin
Priority: critical Milestone: 0.3
Component: server Version: 0.1.0
Keywords: Cc:

Description

After the first session, the server does not accept any further connections correctly. This was bisected to the changes made by r778 and r779. The client revision doesn't matter, only the server.

Attachments (1)

ticket-129.patch​ (474 bytes) - added by Norman Rasmussen 9 years ago.

Download all attachments as: .zip

Change History (4)

comment:1 Changed 9 years ago by Norman Rasmussen

With some debugging I have determined that on _process_connection_lost that _clear_keys_pressed and unpress_all_keys never returns.

r778 made it so that the process_packet(CONNECT_LOST) can run on any of 3 threads (read/writer/main).

There are two possible fixes:

1) change all calls to self.close() in protocol to run via idle_add (like _read_parse_thread_loop does),

2) I think the better fix is to invoke _process_packet_cb using idle_add in close(). A proposed patch is included.

Changed 9 years ago by Norman Rasmussen

Attachment: ticket-129.patch​ added

comment:2 Changed 9 years ago by Antoine Martin

Resolution: → fixed
Status: new → closed

applied in r876 - thanks!

comment:3 Changed 6 months ago by migration script

this ticket has been moved to: ​https://github.com/Xpra-org/xpra/issues/129

Note: See TracTickets for help on using tickets.