xpra icon
Bug tracker and wiki

Opened 4 years ago

Closed 4 years ago

#1337 closed defect (fixed)

xpra_launcher.exe produces a log file alert dialog on exit

Reported by: Antoine Martin Owned by: Antoine Martin
Priority: major Milestone: 1.0
Component: platforms Version: trunk
Keywords: win32 Cc:

Description


Change History (1)

comment:1 Changed 4 years ago by Antoine Martin

Resolution: fixed
Status: newclosed

Bisection: (argb codec needed revision r13763 to build on win32 to test)

Sub-bisecting the large r13756 changeset as there's no obvious problem with it:

  • "client" module revert: no fix
  • "codecs" and "server" module revert: no fix
  • "x11" "net" and "clipboard" module revert: no fix
  • "sound" and "gtk_common" module revert: no fix
  • "platform" module revert fixes it:

Sub-bisecting "platform" module:

  • "platform.win32" is where the problem is.

Sub-bisecting that, leads to this tiny innocuous change as being the source of the problem: http://xpra.org/trac/changeset/13756/xpra#file42.

Somehow, importing "xpra.util" from "xpra.platform.win32" seems to have some bad side-effects, so r14111 delays the import until we actually need it and that fixes the problem.
I don't really understand why, but I don't have time to look into it either.

Note: See TracTickets for help on using tickets.