xpra icon
Bug tracker and wiki

Opened 4 years ago

Closed 4 years ago

#1393 closed defect (fixed)

omit "-p" option to ssh if port not specified

Reported by: Todd Vierling Owned by: Antoine Martin
Priority: minor Milestone:
Component: network Version: trunk
Keywords: Cc:

Description

xpra is now always supplying a "-p" option to ssh to specify the port number (using "-p 22" if not provided).

However, this prevents the use of standard ssh configuration options in ~/.ssh/config where a host's port number can be specified for standard (no-port-specified) ssh commands.

If a ssh connect string contains no port number, xpra should actually omit the "-p" option altogether, allowing ssh itself to properly choose the port for the given hostname (which of course will default to 22 if not otherwise configured). This parallels other standard usage of ssh as a tunneling protocol in other applicaitons.

Change History (1)

comment:1 Changed 4 years ago by Antoine Martin

Resolution: fixed
Status: newclosed

Fixed in r14667 for trunk, backport to v1.0.x in rr14668.

PS: I think that was the case before and that the parse_host_string refactoring lost that. (as the mostly duplicated launcher code still has it..)

Note: See TracTickets for help on using tickets.