Opened 4 years ago
Closed 4 years ago
#1405 closed defect (fixed)
rpath ignored when system libraries are matched first
Reported by: | Antoine Martin | Owned by: | Antoine Martin |
---|---|---|---|
Priority: | blocker | Milestone: | 2.1 |
Component: | packaging | Version: | trunk |
Keywords: | Cc: |
Change History (9)
comment:1 Changed 4 years ago by
Status: | new → assigned |
---|
comment:2 Changed 4 years ago by
Found the first problem: the linker doesn't use our version of the libraries because /usr/lib64/xpra
contains a libvpx.so.4
but /usr/lib64
has a libvpx.so
symlink to libvpx.so.1
and that takes precedence because we link with -lvpx
.
If I manually add a symlink so to libvpx.so.4
under /usr/lib64/xpra/libvpx.so
then the module does get linked against the version of the library we want, but then it crashes during selftests..
comment:3 Changed 4 years ago by
Priority: | major → blocker |
---|
comment:2 was wrong: the problem on this particular system was that the development package libvpx-xpra-devel
was not installed correctly (partially removed?) and it contains the required libvpx.so
symlink and the correct library headers. With this properly installed, all the problems go away.
At least all the unit tests now run... except when they are ran from the rpmbuild command, then the codec self test crashes with memory corruption in vpx!
comment:4 Changed 4 years ago by
comment:5 Changed 4 years ago by
Milestone: | 2.0 → 2.1 |
---|
Likely to cause problems, too late for that. Re-scheduling.
comment:7 Changed 4 years ago by
Owner: | changed from Antoine Martin to Smo |
---|---|
Status: | assigned → new |
Despite using --enable-rpath
with ffmpeg (r15658 for RPM, r15661 for DEB), and setting xpra's PKG_CONFIG_PATH
before calling configure (r15664), we can't re-enable the rpath and undo r14907: the centos builds would then crash during the codecs selftests.. Looks like we still have mismatch somewhere between what we build against and what is used at runtime.
@smo: any ideas?
comment:8 Changed 4 years ago by
Owner: | changed from Smo to Antoine Martin |
---|---|
Status: | new → assigned |
Found the cause of the problem: the centos build ends up missing the "library_dirs" from pkgconfig, and so we build with the wrong headers!
Looks like it is ignoring our PKG_CONFIG_PATH
environment setting.
Running the build command outside rpmbuild does give the expected result and the resulting installation works as expected.
No idea what is different when running from rpmbuild.
comment:9 Changed 4 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
I already had a fix for this: r14750.
Applied to v1.0.x in r14751, also needed r14743 (+ r14744 fixup) to pass the rpath to the setup.py
But since the potential for regressions is high... I am keeping this ticket open, at least until 1.0.2 is released.