xpra icon
Bug tracker and wiki

This bug tracker and wiki are being discontinued
please use https://github.com/Xpra-org/xpra instead.


Changes between Initial Version and Version 1 of Ticket #1414


Ignore:
Timestamp:
01/17/17 15:57:29 (5 years ago)
Author:
Antoine Martin
Comment:

Thanks - will fix ASAP.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #1414

    • Property Status changed from new to assigned
  • Ticket #1414 – Description

    initial v1  
    44
    55In xpra/codecs/nvenc7 the following code checks the version of the NVENC API in init_module() (line 2531):
    6 [[BR]]
     6{{{
     7    if NVENCAPI_VERSION!=0x7:
     8        raise Exception("unsupported version of NVENC: %#x" % NVENCAPI_VERSION)
     9}}}
    710
    8 ''    if NVENCAPI_VERSION!=0x7:
    9         raise Exception("unsupported version of NVENC: %#x" % NVENCAPI_VERSION)''
    10 [[BR]]
    11 
    12 NVENCAPI_VERION comes from header file Samples/common/inc/nvEncodeAPI.h of NVIDIAs NVENC SDK.
     11NVENCAPI_VERION comes from header file {{{Samples/common/inc/nvEncodeAPI.h}}} of NVIDIAs NVENC SDK.
    1312It is defined here like this (line 113):
    14 [[BR]]
    15 
    16 
    17 ''    #define NVENCAPI_VERSION (NVENCAPI_MAJOR_VERSION | (NVENCAPI_MINOR_VERSION << 24))''
    18 [[BR]]
     13{{{
     14    #define NVENCAPI_VERSION (NVENCAPI_MAJOR_VERSION | (NVENCAPI_MINOR_VERSION << 24))''
     15}}}
    1916
    2017This means that NVENCAPI_VERSION looks like this:
     18{{{
    2119    0x0000007 == 0x7 for 7.0
    2220    0x1000007 != 0x7 for 7.1
     21}}}
    2322=> if NVENCAPI_VERSION!=0x7: fails for version 7.1
    2423[[BR]]
    2524
     25{{{
    2626nvEncodeAPI.h also defines
    2727    #define NVENCAPI_MAJOR_VERSION 7
    28 [[BR]]
     28}}}
    2929
    3030A possible fix could be:
    31 ''    if NVENCAPI_MAJOR_VERSION != 7:
    32         raise Exception("unsupported version of NVENC: %#x" % NVENCAPI_MAJOR_VERSION)''
    33 [[BR]]
     31{{{
     32    if NVENCAPI_MAJOR_VERSION != 7:
     33        raise Exception("unsupported version of NVENC: %#x" % NVENCAPI_MAJOR_VERSION)
     34}}}
    3435
    3536Best,