xpra icon
Bug tracker and wiki

Opened 6 years ago

Closed 6 years ago

#149 closed defect (fixed)

use XkbKeycodeToKeysym instead of XKeycodeToKeysym (deprecation)

Reported by: Antoine Martin Owned by: Antoine Martin
Priority: trivial Milestone: 0.8
Component: core Version: trunk
Keywords: keyboard Cc:

Description (last modified by Antoine Martin)

We get these warnings:

/usr/include/gtk-2.0/gtk/gtkitemfactory.h:47:1: warning: function declaration isn't a prototype [-Wstrict-prototypes]
bindings.c: In function '__pyx_f_8wimpiggy_8lowlevel_8bindings_KeysymToKeycodes':
bindings.c:10353:7: warning: 'XKeycodeToKeysym' is deprecated (declared at /usr/include/X11/Xlib.h:1695) [-Wdeprecated-declarations]
bindings.c: In function '__pyx_f_8wimpiggy_8lowlevel_8bindings__get_modifier_mappings':
bindings.c:11494:9: warning: 'XKeycodeToKeysym' is deprecated (declared at /usr/include/X11/Xlib.h:1695) [-Wdeprecated-declarations]
bindings.c: In function '__pyx_pf_8wimpiggy_8lowlevel_8bindings_68get_keycodes_down':
bindings.c:12712:5: warning: 'XKeycodeToKeysym' is deprecated (declared at /usr/include/X11/Xlib.h:1695) [-Wdeprecated-declarations]

See freedesktop.org bug 5349 and freedesktop.org bug 25732

Together with the fix in 108#comment:12, this should fix most keyboard related issues?

Change History (5)

comment:1 Changed 6 years ago by Antoine Martin

Description: modified (diff)
Status: newaccepted

comment:2 Changed 6 years ago by Antoine Martin

We may have to use more than just XkbKeycodeToKeysym... there's a whole new API to use in Xkb, with very little in terms of "howto" documentation.

Maybe we can get away with just figuring out "group" and "level"?

This ought to allow us to fix the following bugs:

  • #108: the only remaining issue that I perceived was with right Alt (ISO_Level_3 shift) + "ß" (right of top row "0") which should produce a "\", but continues to produce a "ß".
  • #109: dvorak-fr

And maybe also:

  • #91: control key with custom xmodmap changes... (should work)
  • #86: 2 keyboards on a client, each with a different layout
Last edited 6 years ago by Antoine Martin (previous) (diff)

comment:3 Changed 6 years ago by Antoine Martin

Description: modified (diff)

comment:4 Changed 6 years ago by Antoine Martin

Milestone: 0.40.8

comment:5 Changed 6 years ago by Antoine Martin

Resolution: fixed
Status: acceptedclosed

done in r1772

Note: See TracTickets for help on using tickets.