xpra icon
Bug tracker and wiki

This bug tracker and wiki are being discontinued
please use https://github.com/Xpra-org/xpra instead.


Opened 9 years ago

Closed 8 years ago

Last modified 6 weeks ago

#151 closed enhancement (wontfix)

fix all gcc compiler warnings that we can fix - strict-aliasing rules

Reported by: Antoine Martin Owned by: Antoine Martin
Priority: minor Milestone: 0.9
Component: core Version: trunk
Keywords: Cc:

Description (last modified by Antoine Martin)

Most of these ones look fixable: "warning: dereferencing type-punned pointer will break strict-aliasing rules" in wimpiggy/lowlevel/bindings.c:

  • __Pyx_PyBoolOrNull_FromLong: twice
  • is_mapped: twice
  • xmodmap_setkeycodes: twice
  • get_raw_modifier_mappings: 4 times
  • xmodmap_clearmodifier: twice
  • xmodmap_addmodifier: 4 times
  • unpress_all_keys: twice
  • native_xmodmap: twice
  • ensure_extension_support: 4 times
  • displayHasXComposite: 4 times
  • has_randr: 4 times
  • set_screen_size: 6 times
  • x_event_filter: 4 times

This one is not (just recording it here) since it needs to be fixed in (py)gtk:

In file included from /usr/include/gtk-2.0/gtk/gtk.h:236:0,
                 from /usr/include/pygtk-2.0/pygtk/pygtk.h:8,
                 from wimpiggy/lowlevel/bindings.c:278:
/usr/include/gtk-2.0/gtk/gtkitemfactory.h:47:1: \
    warning: function declaration isn't a prototype [-Wstrict-prototypes]

Then there are a few more use XkbKeycodeToKeysym instead of XKeycodeToKeysym, see #149

Change History (5)

comment:1 Changed 9 years ago by Antoine Martin

Description: modified (diff)
Status: new → accepted

comment:2 Changed 8 years ago by Antoine Martin

Milestone: 0.4 → 0.8

comment:3 Changed 8 years ago by Antoine Martin

Milestone: 0.8 → 0.9
Summary: fix all gcc compiler warnings that we can fix → fix all gcc compiler warnings that we can fix - strict-aliasing rules
Version 0, edited 8 years ago by Antoine Martin (next)

comment:4 Changed 8 years ago by Antoine Martin

Resolution: → wontfix
Status: accepted → closed

Compiling with Fedora 18 and -Wall does not show a single warning and this is using:

  • gcc (GCC) 4.7.2 20121109 (Red Hat 4.7.2-8)
  • Cython version 0.18

So I think we're good.

comment:5 Changed 6 weeks ago by migration script

this ticket has been moved to: ​https://github.com/Xpra-org/xpra/issues/151

Note: See TracTickets for help on using tickets.