Xpra: Ticket #151: fix all gcc compiler warnings that we can fix - strict-aliasing rules

Most of these ones look fixable: "warning: dereferencing type-punned pointer will break strict-aliasing rules" in wimpiggy/lowlevel/bindings.c:

__Pyx_PyBoolOrNull_FromLong: twice
is_mapped: twice
xmodmap_setkeycodes: twice
get_raw_modifier_mappings: 4 times
xmodmap_clearmodifier: twice
xmodmap_addmodifier: 4 times
unpress_all_keys: twice
native_xmodmap: twice
ensure_extension_support: 4 times
displayHasXComposite: 4 times
has_randr: 4 times
set_screen_size: 6 times
x_event_filter: 4 times

This one is not (just recording it here) since it needs to be fixed in (py)gtk:

In file included from /usr/include/gtk-2.0/gtk/gtk.h:236:0,
                 from /usr/include/pygtk-2.0/pygtk/pygtk.h:8,
                 from wimpiggy/lowlevel/bindings.c:278:
/usr/include/gtk-2.0/gtk/gtkitemfactory.h:47:1: \
    warning: function declaration isn't a prototype [-Wstrict-prototypes]

Then there are a few more use XkbKeycodeToKeysym instead of XKeycodeToKeysym, see #149

Fri, 22 Jun 2012 16:19:26 GMT - Antoine Martin: status, description changed

status changed from new to accepted
description modified (diff)

Thu, 27 Sep 2012 15:23:15 GMT - Antoine Martin: milestone changed

milestone changed from 0.4 to 0.8

Fri, 08 Feb 2013 04:33:45 GMT - Antoine Martin: summary, milestone changed

summary changed from fix all gcc compiler warnings that we can fix to fix all gcc compiler warnings that we can fix - strict-aliasing rules
milestone changed from 0.8 to 0.9

#250 closed as duplicate

Wed, 20 Mar 2013 14:49:37 GMT - Antoine Martin: status changed; resolution set

status changed from accepted to closed
resolution set to wontfix

Compiling with Fedora 18 and -Wall does not show a single warning and this is using:

gcc (GCC) 4.7.2 20121109 (Red Hat 4.7.2-8)
Cython version 0.18

So I think we're good.

Sat, 23 Jan 2021 04:46:55 GMT - migration script:

this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/151