#151 closed enhancement (wontfix)
fix all gcc compiler warnings that we can fix - strict-aliasing rules
Reported by: | Antoine Martin | Owned by: | Antoine Martin |
---|---|---|---|
Priority: | minor | Milestone: | 0.9 |
Component: | core | Version: | trunk |
Keywords: | Cc: |
Description (last modified by )
Most of these ones look fixable: "warning: dereferencing type-punned pointer will break strict-aliasing rules
" in wimpiggy/lowlevel/bindings.c
:
__Pyx_PyBoolOrNull_FromLong
: twiceis_mapped
: twicexmodmap_setkeycodes
: twiceget_raw_modifier_mappings
: 4 timesxmodmap_clearmodifier
: twicexmodmap_addmodifier
: 4 timesunpress_all_keys
: twicenative_xmodmap
: twiceensure_extension_support
: 4 timesdisplayHasXComposite
: 4 timeshas_randr
: 4 timesset_screen_size
: 6 timesx_event_filter
: 4 times
This one is not (just recording it here) since it needs to be fixed in (py)gtk:
In file included from /usr/include/gtk-2.0/gtk/gtk.h:236:0, from /usr/include/pygtk-2.0/pygtk/pygtk.h:8, from wimpiggy/lowlevel/bindings.c:278: /usr/include/gtk-2.0/gtk/gtkitemfactory.h:47:1: \ warning: function declaration isn't a prototype [-Wstrict-prototypes]
Then there are a few more use XkbKeycodeToKeysym instead of XKeycodeToKeysym
, see #149
Change History (5)
comment:1 Changed 9 years ago by
Description: | modified (diff) |
---|---|
Status: | new → accepted |
comment:2 Changed 8 years ago by
Milestone: | 0.4 → 0.8 |
---|
comment:3 Changed 8 years ago by
Milestone: | 0.8 → 0.9 |
---|---|
Summary: | fix all gcc compiler warnings that we can fix → fix all gcc compiler warnings that we can fix - strict-aliasing rules |
Version 0, edited 8 years ago
by
(next)
comment:4 Changed 8 years ago by
Resolution: | → wontfix |
---|---|
Status: | accepted → closed |
Compiling with Fedora 18 and -Wall
does not show a single warning and this is using:
gcc (GCC) 4.7.2 20121109 (Red Hat 4.7.2-8)
Cython version 0.18
So I think we're good.
comment:5 Changed 6 weeks ago by
this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/151
Note: See
TracTickets for help on using
tickets.