xpra icon
Bug tracker and wiki

Opened 4 months ago

Closed 4 weeks ago

#1577 closed task (fixed)

add 10 bit formats to virtualgl

Reported by: Antoine Martin Owned by: Antoine Martin
Priority: major Milestone: 2.2
Component: packaging Version: trunk
Keywords: Cc:

Description

Follow up from #1309.

Without this, it is quite difficult to use the 10 bpc mode.
You get with glxgears:

Error: couldn't get an RGB, Double-buffered visual

AFAICT, this shouldn't be too hard: we don't want anything fancy, no compression support.

Attachments (2)

vgl-30bpc.patch (8.0 KB) - added by Antoine Martin 4 months ago.
patch with debug which adds 30bpc to the X11 transport
vgl-30bpc-minimal.patch (4.2 KB) - added by Antoine Martin 4 months ago.
minimal patch

Download all attachments as: .zip

Change History (6)

comment:1 Changed 4 months ago by Antoine Martin

Milestone: future2.2
Status: newassigned

Worth a try, may not be too hard.

Changed 4 months ago by Antoine Martin

Attachment: vgl-30bpc.patch added

patch with debug which adds 30bpc to the X11 transport

Changed 4 months ago by Antoine Martin

Attachment: vgl-30bpc-minimal.patch added

minimal patch

comment:2 Changed 4 months ago by Antoine Martin

The patch above applies cleanly to current virtualgl 2.5.3 and allows us to forward "r210" pixel data as GL_RGB10_A2 / GL_UNSIGNED_INT_2_10_10_10_REV.

Tested with #1553 and the commands:

  • server:
    xpra start --start-child=xterm --pixel-depth=30
    
  • client: xpra attach
  • test app:
    vglrun -d :1 python xpra/client/gtk_base/example/gl_colors_gradient.py
    

The changes in banding are very noticeable when going from 10 down to 8.

Edit: made a pull request for upstream.

Last edited 4 months ago by Antoine Martin (previous) (diff)

comment:3 Changed 4 weeks ago by Antoine Martin

Latest comment: This unfortunately required more in-depth modifications to VirtualGL, which led me down the rabbit hole of overhauling all of the horribly outdated pixel format and conversion stuff. I should have it checked in by the end of this week.

comment:4 Changed 4 weeks ago by Antoine Martin

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.