xpra icon
Bug tracker and wiki

This bug tracker and wiki are being discontinued
please use https://github.com/Xpra-org/xpra instead.

Opened 4 years ago

Closed 4 years ago

Last modified 16 months ago

#1731 closed defect (fixed)

inconsistent authentication handling

Reported by: Antoine Martin Owned by: J. Max Mena
Priority: blocker Milestone: 2.3
Component: server Version: 2.2.x
Keywords: Cc:


Because TCP sockets can be upgraded to websockets, SSL or both (Secure websockets) - for details see #1504 and wiki/Authentication - the authentication module for the connection is not always the one expected: wrapping with websockets uses the new socket type (ws-auth), but ssl would not! (and a wss upgrade from tcp would use ssl!)

Same problem applies to websockets upgraded to ssl (bind-ws with ssl=on), or ssl sockets upgraded to secure-websockets (bind-ssl with html=on).

Change History (4)

comment:1 Changed 4 years ago by Antoine Martin

Status: newassigned

Minimal? fix in r17798: keep track of the original socket type, use those authentication modules.

Backport still needed. (oh joy)

In the meantime, the easy workaround is to always make sure to set ssl-auth, ws-auth and wss-auth if you are setting tcp-auth.

Last edited 4 years ago by Antoine Martin (previous) (diff)

comment:2 Changed 4 years ago by Antoine Martin

Owner: changed from Antoine Martin to J. Max Mena
Status: assignednew

Backport in r17972.

@mamylyn: FYI, that's a bigger than usual backport.

comment:3 Changed 4 years ago by J. Max Mena

Resolution: fixed
Status: newclosed

Noted and closing.

comment:4 Changed 16 months ago by migration script

this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/1731

Note: See TracTickets for help on using tickets.