inconsistent authentication handling

[Antoine Martin]

Because TCP sockets can be upgraded to websockets, SSL or both (Secure websockets) - for details see #1504 and wiki/Authentication - the authentication module for the connection is not always the one expected: wrapping with websockets uses the new socket type (ws-auth), but ssl would not! (and a wss upgrade from tcp would use ssl!)

Same problem applies to websockets upgraded to ssl (bind-ws with ssl=on), or ssl sockets upgraded to secure-websockets (bind-ssl with html=on).

[Antoine Martin]

Minimal? fix in r17798: keep track of the original socket type, use those authentication modules.

Backport still needed. (oh joy)

In the meantime, the easy workaround is to always make sure to set ssl-auth, ws-auth and wss-auth if you are setting tcp-auth.

[Antoine Martin]

Backport in r17972.

@mamylyn: FYI, that's a bigger than usual backport.

[J. Max Mena]

Noted and closing.

[migration script]

this ticket has been moved to: ​https://github.com/Xpra-org/xpra/issues/1731