xpra icon
Bug tracker and wiki

This bug tracker and wiki are being discontinued
please use https://github.com/Xpra-org/xpra instead.

Opened 4 years ago

Closed 2 years ago

Last modified 16 months ago

#1778 closed task (fixed)

mixins cleanups

Reported by: Antoine Martin Owned by: Antoine Martin
Priority: major Milestone: 4.0
Component: core Version: trunk
Keywords: Cc:

Description (last modified by Antoine Martin)

Follow up from #1761 + #1700.


  • write more unit tests: #1773, also helpful for:
  • identifying leakage of mixin domains: where one mixin relies on another (ie: mmap)
  • messy code:
    • keyboard, ie: modifier_client_keycodes is still too ugly
    • hello packet code
    • init_ui
  • r18656 for window server: remove all window packet handlers if window forwarding is disabled
  • networkstate: pings require statistics object - move it out into its own domain?
  • ServerCore.setup(): we init_auth and init_html_proxy with options, should be split into a parsing step + setup step (means losing support for the legacy password-file - and need another solution for socket_dir in sys-auth-base)
  • more consistent namespace for mixin variables, try to distinguish: settings (command line, env vars), server settings (from hello or update packets), state (focus, buttons, etc)
  • some timers can now be tracked and cancelled more easily (ie: ping timers)

Change History (5)

comment:1 Changed 4 years ago by Antoine Martin

Description: modified (diff)
Status: newassigned
Summary: mixins cleanups and unit testsmixins cleanups

comment:2 Changed 3 years ago by Antoine Martin

server mixins: #1838

client mixins: #1861

comment:3 Changed 3 years ago by Antoine Martin

Milestone: 3.04.0

Things are in pretty good shape already, see links in comment:2.
See also #2362.

The main dependency issues can be clearly seen by looking at the test code:

  • we inject a fake _protocol attribute
  • we inject a fake _server_sources dictionary
  • some other minor attributes (ie: _upgrading flag, session_name, machine_id, etc..) - some could be duplicated, others

comment:4 Changed 2 years ago by Antoine Martin

Resolution: fixed
Status: assignedclosed

This will do for now, follow up in #2578

comment:5 Changed 16 months ago by migration script

this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/1778

Note: See TracTickets for help on using tickets.