Xpra: Ticket #1778: mixins cleanups
Follow up from #1761 + #1700.
Tasks:
- write more unit tests: #1773, also helpful for:
- identifying leakage of mixin domains: where one mixin relies on another (ie: mmap)
- messy code:
- keyboard, ie:
modifier_client_keycodes
is still too ugly
- hello packet code
init_ui
- r18656 for window server: remove all window packet handlers if window forwarding is disabled
- networkstate: pings require statistics object - move it out into its own domain?
ServerCore.setup()
: we init_auth
and init_html_proxy
with options, should be split into a parsing step + setup step (means losing support for the legacy password-file
- and need another solution for socket_dir
in sys-auth-base)
- more consistent namespace for mixin variables, try to distinguish: settings (command line, env vars), server settings (from hello or update packets), state (focus, buttons, etc)
- some timers can now be tracked and cancelled more easily (ie: ping timers)
Wed, 28 Mar 2018 05:22:24 GMT - Antoine Martin: status, description, summary changed
- status
changed from new to assigned
- description
modified (diff)
- summary
changed from mixins cleanups and unit tests to mixins cleanups
Wed, 26 Jun 2019 08:46:21 GMT - Antoine Martin:
server mixins: #1838
client mixins: #1861
Mon, 22 Jul 2019 15:28:50 GMT - Antoine Martin: milestone changed
- milestone
changed from 3.0 to 4.0
Things are in pretty good shape already, see links in comment:2.
See also #2362.
The main dependency issues can be clearly seen by looking at the test code:
- we inject a fake
_protocol
attribute
- we inject a fake
_server_sources
dictionary
- some other minor attributes (ie:
_upgrading
flag, session_name
, machine_id
, etc..) - some could be duplicated, others
Thu, 06 Feb 2020 03:06:57 GMT - Antoine Martin: status changed; resolution set
- status
changed from assigned to closed
- resolution
set to fixed
This will do for now, follow up in #2578
Sat, 23 Jan 2021 05:33:32 GMT - migration script:
this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/1778