#1861 closed enhancement (fixed)
skip client base classes
Reported by: | Antoine Martin | Owned by: | J. Max Mena |
---|---|---|---|
Priority: | major | Milestone: | 2.4 |
Component: | client | Version: | 2.3.x |
Keywords: | Cc: |
Change History (7)
comment:1 Changed 4 years ago by
Status: | new → assigned |
---|
comment:2 Changed 4 years ago by
Updates:
With these changes applied and turning off all the features (including window forwarding..), the client memory usage goes from ~220MB (~280MB without mmap) to just 64MB.
$ ps -eo size,pid,user,command --sort -size | grep xpra | \ awk '{ hr=$1/1024 ; printf("%13.2f MB ",hr) } { \ for ( x=4 ; x<=NF ; x++ ) { printf("%s ",$x) } print "" }' | \ cut -d "" -f2 | \ cut -d "-" -f1 64.65 MB /bin/python /usr/bin/xpra attach
Still TODO:
- spurious clipboard token fix
- memory usage goes up in some cases!?
This one uses 400MB!
$ xpra attach --mmap=no --notifications=no --file-transfer=no --open-files=no \ --open-url=no --printing=no --clipboard=no --system-tray=no --cursors=no \ --bell=no --webcam=no --remote-logging=no --speaker=no --microphone=no \ --av-sync=no --tray=no --windows=yes --dbus-proxy=no
comment:3 Changed 4 years ago by
Owner: | changed from Antoine Martin to J. Max Mena |
---|---|
Status: | assigned → new |
clipboard token fix in r19895, high memory usage moved to #1913.
@maxmylyn: FYI, feel free to close.
When disabling features (ie: --clipboard=no
), the code won't be loaded at all now and the corresponding options are removed from the systray menu.
If a module is not installed (ie: build with ./setup.py build --without-clipboard
), then attempts to enable functionality that relies on this module will trigger a warning.
comment:4 Changed 4 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
Noted, will pass a note along.
Closing.
comment:5 Changed 4 years ago by
With the changes from #1913, the client memory usage goes down from ~220MB to ~130MB when turning off all non-essential options.
comment:7 Changed 16 months ago by
this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/1861
Mostly done in r19885 (+r19886).
ie:
Without turning off features:
TODO / things that could be improved:
tray
andmmap_enabled
attributes are always defined so all mixins can access them (easier - not sure it's worth worrying about)