#1895 closed defect (fixed)
Modal Window in Xpra
Reported by: | ibuprofene | Owned by: | ibuprofene |
---|---|---|---|
Priority: | major | Milestone: | 2.4 |
Component: | client | Version: | 2.3.x |
Keywords: | Cc: |
Description
It is not possible for now to use modal window on xpra. Is it possible to add on option to allow it ?
Change History (16)
comment:1 Changed 3 years ago by
Component: | android → client |
---|---|
Milestone: | → 2.4 |
Owner: | changed from Antoine Martin to ibuprofene |
comment:2 Changed 3 years ago by
Hello,
It doesn't work with my current version: xpra v2.3.1-r19531
I will try with a beta as soon as possible.
I use CENTOS
comment:3 Changed 3 years ago by
It doesn't work with my current version: xpra v2.3.1-r19531
This flag is only in the beta builds at present.
If this works for you, I will then apply it to the stable 2.3.x branch.
I use CENTOS
Which release? 7.5?
comment:4 Changed 3 years ago by
In any case, there are now beta packages for all centos7 releases.
r19869 enabled this by default (since I haven't encountered any problems with it so far - can revert later), adds a command line option (modal-windows=yes|no
) and a toggle in the system tray.
We could also make the tray toggle apply to existing windows, rather than only apply to new windows. (using a setter method on the client to iterate over the windows and set the value from the metadata cache)
comment:5 Changed 3 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
r19906 re-sets the flag on all the windows whenever the value in the system tray menu is toggled.
That will do.
comment:6 Changed 3 years ago by
Ok so I tried the new version of xpra but it didn't work properly, when I start the client it says "VM blacklisted" and it doesn't work.
Notice that it could be another problem, I will try on an other machine and I'll tell you.
comment:7 Changed 3 years ago by
Ok so I tried the new version of xpra but it didn't work properly,
What exact version?
when I start the client it says "VM blacklisted"..
What is the exact message? Is this the opengl message? (this one has not changed at all for a while)
and it doesn't work
What is "it"?
The client? The connection? The modal windows?
comment:8 Changed 3 years ago by
Hello, thank you for your reactivity:
xpra v2.4-r19869
Yes it was the openGL message, I don't have this issue anymore.
The "it" is the whole thing, when I start the client both client and servers crash
comment:9 Changed 3 years ago by
The "it" is the whole thing, when I start the client both client and servers crash
That's very very unlikely.
What is the client output and server log?
comment:10 Changed 3 years ago by
Well I'm not working on this machine anymore so I cannot tell you exactly what was the output, I will have access tomorrow when I'll go back to my work, I'll send you evrything then.
I have just created a new VM with centos 7.5 to test your patch, so I've installed xpra and xpra --version returns: xpra v2.4-r19869
So I think it is the good one
Then I use the following comand line:
xpra start :99 --daemon=no --start-via-proxy=no --webcam=no --start-new-commands=yes \ --encodings=rgb,png,h264,vp8,vp9 --quality=100 --min-quality=95 --pixel-depth=24 \ --mdns=no --html=yes --bind-tcp=0.0.0.0:1203 --pulseaudio=no --resize-display=no \ --file-transfer=yes --printing=no --speaker=disabled --microphone=disabled \ --exit-with-children --modal-windows=yes --start-child="myapp"
on server and I use the browser to connect and I don't have my modal window, but I think I miss something, I don't understand what you mean by " a toggle in the system tray", is there something else to do ?
Thank you again
comment:11 Changed 3 years ago by
and I use the browser to connect
You must be joking. You are using the HTML5 client and you only mention this in comment:10. All the work I did was for the regular python client.
Please file a separate ticket for that, and make it clear that this is for the HTML5 client as per wiki/ReportingBugs.
comment:12 Changed 3 years ago by
No you did well, so far I was using the python client but yesterday as I hadn't xpra on my machine I tried with the browser, I thought It was the same, sorry, I apologize, but anyway even with the python client I don't have my modal window :(
comment:13 Changed 3 years ago by
Ok so I came back on my computer and I realized that I had edited some env variables and there was aparently a conflit between my X server and Xpra so I changed it and now it's fine, and wow the modal works ! Thank you very much !
Excuse me if I wasn't clear sometimes, I'll try to be more precise in the future because I have an other bug to report.
comment:14 Changed 22 months ago by
Caused a regression: #2270, so this is now disabled again by default in 2.5.x - a different fix has been applied for 3.0. (see ticket:2270#comment:4 for details)
comment:16 Changed 2 days ago by
this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/1895
Done in r19834.
If you start the client with
XPRA_MODAL_WINDOWS=1
then the client will set the modal flag on windows.@ibuprofene: does that work for you?
some beta packages posted here: https://xpra.org/beta
(let me know if your distro doesn't have builds recent enough)
We could turn this option into a tray menu toggle. (but I'm not sure if toggling the modal flag would affect existing windows properly or not)