Xpra: Ticket #1912: switch for bandwidth detection

See #999, #1855 and #1911.

We should make it easier to disable bandwidth detection, from the client. Not sure if we should turn off detection if the server or client supplies a limit already.

Sun, 08 Jul 2018 09:25:21 GMT - Antoine Martin: status changed

status changed from new to assigned

Mostly done in r19878 + r19880, the server and client can set the detection on or off (still defaults to on):

xpra attach --mmap=no --bandwidth-detection=no

And the value can be seen with:

$ xpra info | grep bandwidth-limit.detection
client.bandwidth-limit.detection=False

Tue, 10 Jul 2018 12:59:14 GMT - Antoine Martin:

r19905 adds a "Turn off" option to the congestion notification actions.

It would be nice to add a similar option to the client's system tray menu, but this would require:

forwarding the flag from server to client via "settings-changed" mechanism
syncing that with a new menu-entry
augmenting the "bandwidth-limit" request packet with this new flag to allow the client to toggle at will

Mon, 01 Oct 2018 16:38:47 GMT - Antoine Martin: owner, status changed

owner changed from Antoine Martin to J. Max Mena
status changed from assigned to new

Too late for 2.4, moving the UI bits to #1972

@maxmylyn: FYI, this new switch makes it easier to rule out problems with the bandwidth detection code.

Tue, 09 Oct 2018 17:51:39 GMT - J. Max Mena: status changed; resolution set

status changed from new to closed
resolution set to fixed

Noted and closing.

Sat, 23 Jan 2021 05:37:06 GMT - migration script:

this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/1912