#1954 closed enhancement (fixed)
remove pixel copy in opengl backend
| Reported by: | Antoine Martin | Owned by: | J. Max Mena |
|---|---|---|---|
| Priority: | major | Milestone: | 2.4 |
| Component: | client | Version: | 2.3.x |
| Keywords: | Cc: |
Description
As identified in #1953, we call clone_plane via img.clone_pixel_data() in the opengl backend.
This was done back in r8069 to fix some tricky compatibility issues with older versions of pyopengl / python (see #717). See also r8111.
We should now be able to remove the extra pixel copy when zerocopy is supported. (new python, new pyopengl with match pyopengl-accelerate)
Change History (3)
comment:1 Changed 3 years ago by
| Owner: | changed from Antoine Martin to J. Max Mena |
|---|
comment:2 Changed 3 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Noted and closing.
I've checked this on my OpenGL enabled machines and everything works fine.
comment:3 Changed 3 months ago by
this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/1954
Note: See
TracTickets for help on using
tickets.
copyleft 2010 - 2021
Done in r20370.
r20371 adds an environment variable to revert to the slower clone pixel mode:
@maxmylyn: FYI, if I got this wrong then this may cause opengl rendering crashes.