xpra icon
Bug tracker and wiki

This bug tracker and wiki are being discontinued
please use https://github.com/Xpra-org/xpra instead.

Opened 4 years ago

Closed 2 years ago

Last modified 16 months ago

#1957 closed enhancement (worksforme)

preemptive use of the bandwidth-limit in video encoders

Reported by: Antoine Martin Owned by: Smo
Priority: major Milestone: 2.4
Component: encodings Version: 2.3.x
Keywords: Cc:

Description (last modified by Antoine Martin)

The bandwidth-limit is used to raise the batch delay (variable refresh rate) so that we stay within budget (and that in turns has an effect on quality and speed), but we should pass the information down to the video encoders so that they can be tuned adequately earlier.

This bitrate constraint overrules the speed and quality settings so this should only be applied when the bandwidth-limit is relatively low.

Somewhat related to #1951, #1840, #1952

Change History (7)

comment:1 Changed 4 years ago by Antoine Martin

Description: modified (diff)
Owner: changed from Antoine Martin to J. Max Mena

Done in r20399 for x264 and vpx.
We only use the bandwidth-limit value when speed and quality are on "auto" and when min-quality is lower than 50%.

The change also improves the amount of x264 encoder configuration details shown in xpra info, so we can see which "rc-method" is in use, ie trimmed:

Last edited 4 years ago by Antoine Martin (previous) (diff)

comment:2 Changed 3 years ago by Antoine Martin

Regression introduced by r20399 is fixed: ticket:2087#comment:4

comment:3 Changed 3 years ago by Antoine Martin

Summary: this new code should allow the video encoders to be better tuned for the amount of bandwidth available, lowering the picture quality (sometimes drastically - see #2087 for what a 2Mbps limit does) but allowing for a higher refresh rate and a better quality for the non-video areas around it.

comment:4 Changed 3 years ago by Antoine Martin

Owner: changed from J. Max Mena to Jonathan Anthony

comment:5 Changed 3 years ago by Smo

Owner: changed from Jonathan Anthony to Smo

comment:6 Changed 2 years ago by Antoine Martin

Resolution: worksforme
Status: newclosed

Not heard back.

comment:7 Changed 16 months ago by migration script

this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/1957

Note: See TracTickets for help on using tickets.