IE11 Support

[Mark Harkin]

@Antoine Looks like I'm a little late on this as I think you've covered most of this in r20580 but maybe missing:

Fullscreen request:​Added IE11 fullscreen request

startsWith and includes Polyfills
My approach was to add a seperate polyfill script so it's easier to remove when IE finally dies. For reference ​added IE11 compatability

[Antoine Martin]

Merged in r20583, thanks.

Can you please specify what copyright applies to those polyfills? (should be the same as ECMA6 I guess - looks like a BSD variant?)

[Mark Harkin]

Sorry, started here ​https://github.com/paulmillr/es6-shim (MIT) but it was overkill for a few polyfills so ended up just grabbing them from elsewhere, I've already give myself a slap on the wrists!

Just tested r20584 but I think:

window.console = window.console || {
	  log: function () {}
};
	

needs to be in index.html otherwise Developer tools needs to be open.

[Antoine Martin]

needs to be in index.html otherwise Developer tools needs to be open.

No idea where that needs to go, I've tried a few obvious places and none helped.
(and since having the developer console open "fixes" things, catch 22)

[Mark Harkin]

Sorry my mistake I should have tidied up before submitting the change:

What's missing is actually (1st diff from ​https://github.com/mjharkin/Xpra/commit/5904fe329d9b1f11acffd65435ddd49ed2406f32 )
This could equally be added to es6-shim.js instead of index.html, depends on your preference.

var console = console || { log: function(){} };

The following should be removed from es6-shim.js

window.console = window.console || {
	  log: function () {}
};

[Antoine Martin]

Thanks, applied in r20592.

Can we close this ticket?

[Mark Harkin]

r20592 changes in index.html and connect.html can be removed.
Otherwise this is good to close.

Thanks.

[Antoine Martin]

Good catch, done in r20593.

[Mark Harkin]

Try catch blocks without an argument were added recently.
IE11 doesn't like this, fix is to add the argument:

​https://github.com/mjharkin/Xpra/commit/a3258e719be86f3705a2dc57442e594493efe4d0

[Antoine Martin]

Thanks!
Applied in r21961.

[migration script]

this ticket has been moved to: ​https://github.com/Xpra-org/xpra/issues/1973