#2032 closed defect (fixed)
The spawned X server stays alive when xpra killed before a display number is assigned
| Reported by: | berserker | Owned by: | berserker |
|---|---|---|---|
| Priority: | major | Milestone: | 2.5 |
| Component: | server | Version: | 2.4.x |
| Keywords: | Cc: |
Description (last modified by )
The reason is that the function killing the X server is added to the Xpra exit cleanup list only after the display number is assigned, see
browser/xpra/trunk/src/xpra/scripts/server.py and
browser/xpra/trunk/src/xpra/scripts/server.py.
Change History (12)
comment:1 Changed 3 years ago by
| Description: | modified (diff) |
|---|---|
| Priority: | critical → major |
| Status: | new → assigned |
comment:2 Changed 3 years ago by
I don't see how this bug is critical
When starting Xpra, sporadically I get the following error:
xpra initialization error:
xpra_Xdummy: did not provide a display number using displayfd
Terminating Xpra does not terminate X server in this case! And you "don't see how this is critical"...
comment:3 Changed 3 years ago by
xpra_Xdummy: did not provide a display number using displayfd
This can happen if your system is really slow.
You can try to change the default timeout:
XPRA_DISPLAY_FD_TIMEOUT=30 xpra start ...
comment:4 Changed 3 years ago by
This can happen if your system is really slow.
Well, kinda. But the question really is why it lets Xorg to continue running after the error occurs?
comment:5 Changed 3 years ago by
| Owner: | changed from Antoine Martin to berserker |
|---|---|
| Status: | assigned → new |
Well, kinda.
what other possibility is there that I am missing?
But the question really is why it lets Xorg to continue running after the error occurs?
Because no-one hit that bug until now?
Fixed for me in r20968. Tested with an unreasonably low timeout value:
XPRA_DISPLAY_FD_TIMEOUT=1 python2 /usr/bin/xpra start --no-daemon -d x11
@berserker: please close if that works for you.
comment:6 Changed 3 years ago by
| Owner: | changed from berserker to Antoine Martin |
|---|
what other possibility is there that I am missing?
Nothing. The system is indeed slow and on top of that users have CPU limits. This makes it easy to trigger the timeout if try to start several Xpra servers simultaneously.
please close if that works for you
Ehm... r20968 is not a fix for the bug reported, even if it solves the problem with timeouts (not checked yet).
comment:7 follow-up: 8 Changed 3 years ago by
| Owner: | changed from Antoine Martin to berserker |
|---|
Ehm... r20968 is not a fix for the bug reported
It is meant to be.
even if it solves the problem with timeouts (not checked yet).
Timeouts are the only unhandled error path I could find that could cause the cleanups to be skipped.
If you can still reproduce a problem, please post the full output of:
XPRA_ALL_DEBUG=1 xpra start ....
comment:8 Changed 3 years ago by
| Owner: | changed from berserker to Antoine Martin |
|---|
Replying to Antoine Martin:
Timeouts are the only unhandled error path I could find that could cause the cleanups to be skipped.
There is also Ctrl+C.
comment:9 Changed 3 years ago by
| Owner: | changed from Antoine Martin to berserker |
|---|
There is also Ctrl+C.
Right. That is only a problem now because of a recent bug somewhere in python's atexit: #1943 (this used to work fine before, no idea when / what library broke it)
comment:10 Changed 3 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:11 Changed 3 years ago by
See also: #2091 which explains why we now hit the timeout more often than before.
comment:12 Changed 8 months ago by
this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/2032
copyleft 2010 - 2021
It's not easy to change this, the
kill_displayfunction is also used for display upgrades.I don't see how this bug is critical: don't kill xpra shortly after starting it and this won't be an issue.