#217 closed enhancement (fixed)
Expose client hostname as capability/stat/info
| Reported by: | Norman Rasmussen | Owned by: | Antoine Martin |
|---|---|---|---|
| Priority: | trivial | Milestone: | 0.8 |
| Component: | core | Version: | trunk |
| Keywords: | Cc: |
Description
I know there's already uuid, but it would be nice to display hostname as well, to make it easier to distinguish clients to humans.
Change History (4)
comment:1 Changed 8 years ago by
| Milestone: | future → 0.8 |
|---|---|
| Status: | new → accepted |
comment:2 Changed 8 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | accepted → closed |
done in r2209, here is a sample log message from the server:
2012-12-09 17:01:02,957 Python/Gtk linux2 client version 0.8.0 connected from 'desktop'
Note: the uuid has been dropped to "debug" log level, and we also show the server's hostname on the session info 'Connection' tab.
comment:3 Changed 8 years ago by
No such thing as an easy/cheap change.. Spent a few hours trying to figure out why I was getting random hangs, until I narrowed it down on this change.
Calling socket.gethostname and socket.getfqdn can be expensive at times (5 seconds or more) so we now do it on startup only (see r2217) - we may even want to do this in a separate thread to allow the server to start quicker, which would also mean accepting the first client before these values are available.
comment:4 Changed 6 weeks ago by
this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/217
copyleft 2010 - 2021
easily done, and the info stuff is due some work anyway