xpra icon
Bug tracker and wiki

This bug tracker and wiki are being discontinued
please use https://github.com/Xpra-org/xpra instead.


Opened 3 years ago

Closed 3 years ago

Last modified 17 months ago

#2326 closed defect (fixed)

capslock not detected

Reported by: Antoine Martin Owned by: Antoine Martin
Priority: critical Milestone: 3.0
Component: html5 Version: 2.5.x
Keywords: Cc:

Description

Broke at some point and I didn't notice.

Change History (3)

comment:1 Changed 3 years ago by Antoine Martin

Status: new → assigned

That's because the keypress event no longer fires. (either something changed in jquery or chrome)
Trivial fix in r22909.

Since event.getModifierState seems to work well, r22910 also switches to that for numlock and removes the keypress event handler hack completely.

Needs testing with all browsers... because the result matrix for this API call is "interesting", see ​MDN: getModifierState
This fiddle can be used for quick testing: ​http://jsfiddle.net/Mottie/a6nhqvv0/

Last edited 3 years ago by Antoine Martin (previous) (diff)

comment:2 Changed 3 years ago by Antoine Martin

Resolution: → fixed
Status: assigned → closed

Tested OK on all supported browsers, including old versions of Safari, Firefox and chrome on Linux and Windows.

comment:3 Changed 17 months ago by migration script

this ticket has been moved to: ​https://github.com/Xpra-org/xpra/issues/2326

Note: See TracTickets for help on using tickets.