Xpra: Ticket #2533: xpra upgrade subcommand regression

As reported in ticket:2524#comment:3.

Easily reproducible, also affects version 3 with both python2 and python3. Odd because I'm pretty sure I had tested this when I added the "upgrade-desktop" and "upgrade-shadow" subcommands.

Sat, 28 Dec 2019 17:33:45 GMT - stdedos: cc set

Sat, 28 Dec 2019 17:46:11 GMT - Antoine Martin: status changed; cc deleted


So the problem is r20757 and it's a big changeset...

Sat, 28 Dec 2019 18:16:51 GMT - stdedos: cc set

Isn't CC how you watch a ticket in Trac?

I hope it's okay to track when this is fixed - especially since it seems it will be a bit long time. :/

Sat, 28 Dec 2019 21:34:15 GMT - Antoine Martin:

Starting from r20757 and reverting the changes to selection.py fixes the problem. Narrowing it further points to this specific change:

self.clipboard.set_with_data([("VERSION", 0, 0)],

changed to:

set_clipboard_data(self.clipboard, "VERSION")

That's because although the documentation does refer to it, set_with_data is no longer exposed with GTK3: gtk_clipboard_set_with_data/set_with_owner is binding-unfriendly.

So we need to change two things:

Sun, 29 Dec 2019 17:17:50 GMT - Antoine Martin:

Working fix in r24834 + r24835.

Still TODO:

Sun, 29 Dec 2019 20:29:32 GMT - Antoine Martin: status changed; resolution set


Sat, 23 Jan 2021 05:53:51 GMT - migration script:

this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/2533