Opened 12 months ago
Last modified 3 months ago
#2556 assigned enhancement
rate limit xdg-menu packets
| Reported by: | Antoine Martin | Owned by: | Antoine Martin |
|---|---|---|---|
| Priority: | critical | Milestone: | 4.2 |
| Component: | core | Version: | 3.0.x |
| Keywords: | Cc: |
Description (last modified by )
This packet sent at the start is getting close to 1MB, mostly because of all the icon data we send with each menu entry.
To fix:
- add a new
setting_change_attributecapability to clients - add an extra flag to the
setting-changepacket sent bysend_setting_changeso we can replace-or-update (0=replace) - send
xdg-menudata one key at a time (one menu at a time), using 1=update - optional: extra marker flag for "end of updates"? (so the client knows it is a good time to update its UI)
Change History (4)
comment:1 Changed 12 months ago by
| Description: | modified (diff) |
|---|---|
| Status: | new → assigned |
comment:2 Changed 9 months ago by
| Priority: | major → critical |
|---|
comment:3 Changed 4 months ago by
| Milestone: | 4.1 → 4.2 |
|---|
comment:4 Changed 3 months ago by
It actually broke through the 1MB barrier today and caused the client connection to drop!
Disconnecting client /run/xpra/localhost.localdomain-2: packet size requested is 1719771 but maximum allowed is 1048576
Mostly because of some humongous icons.
Note: See
TracTickets for help on using
tickets.
copyleft 2010 - 2020
Important for slow connections, raising.
See also #2815.