xpra icon
Bug tracker and wiki

This bug tracker and wiki are being discontinued
please use https://github.com/Xpra-org/xpra instead.


Opened 18 months ago

Closed 18 months ago

Last modified 8 months ago

#2701 closed enhancement (fixed)

changes to JS

Reported by: brief Owned by: Antoine Martin
Priority: trivial Milestone: 4.0
Component: html5 Version: 3.0.x
Keywords: Cc:

Description

Hi,

I made some small changes to JS:

  • use let/const instead of var
  • insert missing/remove extra semicolons
  • declare some vars

The patches are attached.

Are there guidelines for JS formatting? I can't identify a consistent style :)

Attachments (3)

var-let-const.patch​ (135.9 KB) - added by brief 18 months ago.
add-remove-semicolons2.patch​ (42.8 KB) - added by brief 18 months ago.
missing-declaration2.patch​ (1.3 KB) - added by brief 18 months ago.

Download all attachments as: .zip

Change History (7)

Changed 18 months ago by brief

Attachment: var-let-const.patch​ added

comment:1 Changed 18 months ago by brief

Line breaks broke the patch.

Changed 18 months ago by brief

Attachment: add-remove-semicolons2.patch​ added

Changed 18 months ago by brief

Attachment: missing-declaration2.patch​ added

comment:2 Changed 18 months ago by Antoine Martin

Resolution: → fixed
Status: new → closed

Awesome, thank you!

Applied in r25908 + r25909 + r25910.

comment:3 Changed 18 months ago by stdedos

@Antoine: If interested, you could use ESLint (​https://eslint.org/) for this part of the project.

It's easy to inherit the "recommended" configuration, and/or other's template configuration - and you can still make it as much opinionated as you want.

comment:4 Changed 8 months ago by migration script

this ticket has been moved to: ​https://github.com/Xpra-org/xpra/issues/2701

Note: See TracTickets for help on using tickets.