#2701 closed enhancement (fixed)
changes to JS
Reported by: | brief | Owned by: | Antoine Martin |
---|---|---|---|
Priority: | trivial | Milestone: | 4.0 |
Component: | html5 | Version: | 3.0.x |
Keywords: | Cc: |
Description
Hi,
I made some small changes to JS:
- use let/const instead of var
- insert missing/remove extra semicolons
- declare some vars
The patches are attached.
Are there guidelines for JS formatting? I can't identify a consistent style :)
Attachments (3)
Change History (7)
Changed 13 months ago by
Attachment: | var-let-const.patch added |
---|
comment:1 Changed 13 months ago by
Changed 13 months ago by
Attachment: | add-remove-semicolons2.patch added |
---|
Changed 13 months ago by
Attachment: | missing-declaration2.patch added |
---|
comment:2 Changed 13 months ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:3 Changed 13 months ago by
@Antoine: If interested, you could use ESLint (https://eslint.org/) for this part of the project.
It's easy to inherit the "recommended" configuration, and/or other's template configuration - and you can still make it as much opinionated as you want.
comment:4 Changed 3 months ago by
this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/2701
Note: See
TracTickets for help on using
tickets.
Line breaks broke the patch.