xpra icon
Bug tracker and wiki

This bug tracker and wiki are being discontinued
please use https://github.com/Xpra-org/xpra instead.


Changes between Initial Version and Version 1 of Ticket #2793, comment 8


Ignore:
Timestamp:
06/04/20 15:30:25 (16 months ago)
Author:
Antoine Martin
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #2793, comment 8

    initial v1  
     1Almost identical to #2431.
     2
    13`AES` packets are padded to the next 32-byte boundary (that's just how CBC mode operates) and when authentication is enabled, this will be used on the `challenge` packets, before we get a chance to parse the `hello` packets fully, before we can disable legacy compatibility mode.
    24And legacy mode was buggy with padded packets (must have been broken since #2121): the xpra header uses the non-padded packet size, but websocket framing requires the full packet size. (this explains why the browsers were failing to parse websocket frames)