xpra icon
Bug tracker and wiki

This bug tracker and wiki are being discontinued
please use https://github.com/Xpra-org/xpra instead.


Opened 8 months ago

Closed 8 months ago

Last modified 4 months ago

#2881 closed enhancement (fixed)

generate .xpra file from html5 client connect form

Reported by: Antoine Martin Owned by: Mark Harkin
Priority: major Milestone: 4.1
Component: html5 Version: 3.0.x
Keywords: Cc:

Description

Suggested in #2874.

Change History (7)

comment:1 Changed 8 months ago by Antoine Martin

Owner: changed from Antoine Martin to Mark Harkin
  • r27565 preparatory refactoring
  • r27567 add button to launch the native client via a URI (run update-mime-database after installing the updated desktop files)
  • r27569 connection file download link

I think the URI launch is much better than using the connection file, but both are there.

@mjharkin: does that work for you?

comment:2 in reply to:  1 Changed 8 months ago by Mark Harkin

@mjharkin: does that work for you?

From a quick test looks very good, thanks. I'll give it a bit more testing in the next few days. only tested connection files so far.

For windows /win32/xpra.iss will need to be updated with custom protocol renaming.


Also would be nice to have connect.html port set to 80/443 based on window.location.protocol if not explicitly set in url

comment:3 Changed 8 months ago by Antoine Martin

For windows /win32/xpra.iss will need to be updated with custom protocol renaming.

Ooops, thanks. Done in r27573.

Also would be nice to have connect.html port set to 80/443 based on window.location.protocol if not explicitly set in url

Ah, right, I always test with high ports and those do get populated...
Does r27574 work for you?

comment:4 in reply to:  3 Changed 8 months ago by Mark Harkin

Replying to Antoine Martin:

Does r27574 work for you?

Doesn't seem to work and I think maybe this is more generic ​https://github.com/mjharkin/Xpra/commit/a0ede788624bdc219a3f0a253ac96b54e9775e1f

comment:5 Changed 8 months ago by Antoine Martin

Doesn't seem to work and I think maybe this is more generic

Thanks, applied in r27577.

Can we close this ticket?

comment:6 in reply to:  5 Changed 8 months ago by Mark Harkin

Resolution: → fixed
Status: new → closed

Replying to Antoine Martin:

Doesn't seem to work and I think maybe this is more generic

Thanks, applied in r27577.

Can we close this ticket?

Looks good, thanks. Yes, let's close this.

comment:7 Changed 4 months ago by migration script

this ticket has been moved to: ​https://github.com/Xpra-org/xpra/issues/2881

Note: See TracTickets for help on using tickets.