xpra seamless client crash in SublimeMerge right-click crash

[stdedos]

Doing a right-click in Sublime Merge just crashed

"Xpra-Python3-x86_64_4.1-r27892\xpra_cmd" attach ssh://user@ip/3 --ssh="plink -ssh -agent" --modal-windows=no --title="@title@ on @@/@server-display@" --headerbar=off --opengl=no --bandwidth-limit=6Mbps

XPRA_CUSTOM_TITLE_BAR=0
XPRA_EXECUTABLE=Xpra-Python3-x86_64_4.1-r27892
XPRA_REPAINT_ALL=1
XPRA_SCROLL_ENCODING=0

2020-11-16 11:05:03,035 Xpra GTK3 client version 4.1-r27892 64-bit
2020-11-16 11:05:03,038  running on Microsoft Windows 10
2020-11-16 11:05:06,172 GStreamer version 1.18.1 for Python 3.8.6 64-bit
2020-11-16 11:05:07,350 created named pipe 'Xpra\15596'
2020-11-16 11:05:08,196 keyboard layout code 0x409
2020-11-16 11:05:08,198 identified as 'United States - English' : us
2020-11-16 11:05:09,045  keyboard settings: layout=us
2020-11-16 11:05:09,049  desktop size is 4160x1440 with 1 screen:
2020-11-16 11:05:09,049   Default (1100x381 mm - DPI: 96x96) workarea: 4160x1400
2020-11-16 11:05:09,050     Generic PnP Monitor 1600x900 at 0x534 (309x174 mm - DPI: 131x131) workarea: 1600x860 at 0x534
2020-11-16 11:05:09,050     C32JG5x 2560x1440 at 1600x0 (697x392 mm - DPI: 93x93) workarea: 2560x1400 at 1600x0
2020-11-16 11:05:15,652 enabled remote logging
2020-11-16 11:05:15,654 Xpra GTK3 X11 server version 3.0.12-r27620 64-bit
2020-11-16 11:05:15,654  running on Linux Ubuntu 16.04 xenial
2020-11-16 11:05:15,664 Attached to ip:22
2020-11-16 11:05:15,666  (press Control-C to detach)


(xpra_cmd:15596): Pango-WARNING **: 11:05:16.268: couldn't load font "Bitstream Vera Sans Not-Rotated 14.662109375", falling back to "Sans Not-Rotated 14.662109375", expect ugly output.
2020-11-16 11:05:17,314 UI thread is now blocked
2020-11-16 11:05:18,220 UI thread is running again, resuming
2020-11-16 11:07:26,246 Warning: failed to set clipboard data
2020-11-16 11:07:26,258  OpenClipboard: too many failed attempts, giving up
2020-11-16 11:08:25,251 Warning: failed to set clipboard data
2020-11-16 11:08:25,254  OpenClipboard: too many failed attempts, giving up
2020-11-16 11:10:02,432 UI thread is now blocked
2020-11-16 11:10:02,506 UI thread is running again, resuming
2020-11-16 11:10:47,072 Warning: failed to set clipboard data
2020-11-16 11:10:47,076  OpenClipboard: too many failed attempts, giving up
2020-11-16 13:45:52,267 Error: failed to set tray icon
Traceback (most recent call last):
  File "E:\Xpra\trunk\src/xpra/platform/win32/win32_NotifyIcon.py", line 177, in make_ICONINFO
OSError: [WinError 87] The parameter is incorrect.
2020-11-16 13:45:53,271 Error: failed to set tray icon

[......]

2020-11-16 13:59:58,719 Error: failed to set tray icon
Traceback (most recent call last):
  File "E:\Xpra\trunk\src/xpra/platform/win32/win32_NotifyIcon.py", line 167, in make_ICONINFO
  File "E:\Xpra\trunk\src/xpra/platform/win32/win32_NotifyIcon.py", line 212, in rgb_to_bitmap
OSError: [WinError 87] The parameter is incorrect.
_create_dc_and_bitmap: The parameter is incorrect.
_create_dc_and_bitmap: The parameter is incorrect.
_create_dc_and_bitmap: The parameter is incorrect.
_create_dc_and_bitmap: The operation completed successfully.

(xpra_cmd:15596): Gdk-CRITICAL **: 13:59:58.853: gdk_pixbuf_get_from_surface: assertion 'width > 0 && height > 0' failed

(xpra_cmd:15596): Gdk-CRITICAL **: 13:59:58.864: _gdk_win32_display_get_cursor_for_surface: assertion 'GDK_IS_PIXBUF (pixbuf)' failed
2020-11-16 13:59:58,882 error creating cursor: constructor returned NULL (using default)
Traceback (most recent call last):
  File "E:\Xpra\trunk\src/xpra/client/gtk_base/gtk_client_base.py", line 828, in set_windows_cursor
  File "E:\Xpra\trunk\src/xpra/client/gtk_base/gtk_client_base.py", line 953, in make_cursor
TypeError: constructor returned NULL
_create_dc_and_bitmap: The parameter is incorrect.
_create_dc_and_bitmap: The parameter is incorrect.
_create_dc_and_bitmap: The parameter is incorrect.
_create_dc_and_bitmap: The parameter is incorrect.
_create_dc_and_bitmap: The parameter is incorrect.
_create_dc_and_bitmap: The parameter is incorrect.
_create_dc_and_bitmap: The parameter is incorrect.
_create_dc_and_bitmap: The parameter is incorrect.
_create_dc_and_bitmap: The parameter is incorrect.
_create_dc_and_bitmap: The parameter is incorrect.
_create_dc_and_bitmap: The parameter is incorrect.
_create_dc_and_bitmap: The parameter is incorrect.
_create_dc_and_bitmap: The parameter is incorrect.
2020-11-16 14:00:00,535 UI thread is now blocked

However, the log is 330k long - I will just attach it, along with the server's one.

I also have two xpra cores (1.1G and 600M) and obviously I cannot upload them.
Let me know if you need them.

[Antoine Martin]

This looks like a leak of some sort.

Eventually we reach the point where we can't access the UI any more and bad-things-happen(tm).
I'm not aware of any tools that would help in identifying such leaks on win32.
Prime suspects would be the tray icon and the cursor code, as both show up in that log sample.

Please try r27979, which adds extra debug logging with -d win32.
You may also want to run with --cursors=no, maybe it will fix things which would indicate that the bug is in the cursor code.
Note: it's likely to take time to reach the point where the leak causes serious problems.

[Antoine Martin]

We already have a ticket for this: #2738.

[migration script]

this ticket has been moved to: ​https://github.com/Xpra-org/xpra/issues/2941