#2953 closed defect (duplicate)
upnp_add on udp never called
Reported by: | brief | Owned by: | Antoine Martin |
---|---|---|---|
Priority: | minor | Milestone: | 4.1 |
Component: | server | Version: | trunk |
Keywords: | Cc: |
Description (last modified by )
While investigating #2125, I found that upnp_add
in socket_util.py
is not added to upnp_cleanup
since the contained method returns early on udp.
I otherwise discovered the message "#TODO: just like add_listen_socket above, this needs refactoring" in _new_connection
and I gave it a shot: refactor_listenSocket.patch
.
Perhaps I found a bug: should "self.sockets.update(local_sockets)
" in network_listener:57
be called only if opts.bind
? If so, an indent is missing.
Change History (4)
comment:1 Changed 5 months ago by
Component: | android → server |
---|---|
Priority: | major → minor |
Version: | 3.0.x → trunk |
comment:2 Changed 5 months ago by
Resolution: | → duplicate |
---|---|
Status: | new → closed |
comment:3 Changed 5 months ago by
Description: | modified (diff) |
---|
comment:4 Changed 3 months ago by
this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/2953
Note: See
TracTickets for help on using
tickets.
Not sure why you closed as
duplicate
, there was no reason for UDP to be excluded from the upnp code: r28018 fixes that.It should work (just not with the router I am using today):
Indeed!
Fixed in r28019.