xpra icon
Bug tracker and wiki

This bug tracker and wiki are being discontinued
please use https://github.com/Xpra-org/xpra instead.


Opened 8 months ago

Closed 8 months ago

Last modified 6 months ago

#2953 closed defect (duplicate)

upnp_add on udp never called

Reported by: brief Owned by: Antoine Martin
Priority: minor Milestone: 4.1
Component: server Version: trunk
Keywords: Cc:

Description (last modified by Antoine Martin)

While investigating #2125, I found that upnp_add in socket_util.py is not added to upnp_cleanup since the contained method returns early on udp.

I otherwise discovered the message "#TODO: just like add_listen_socket above, this needs refactoring" in _new_connection and I gave it a shot: refactor_listenSocket.patch.

Perhaps I found a bug: should "self.sockets.update(local_sockets)" in network_listener:57 be called only if opts.bind? If so, an indent is missing.

Change History (4)

comment:1 Changed 8 months ago by brief

Component: androidserver
Priority: majorminor
Version: 3.0.xtrunk

comment:2 Changed 8 months ago by brief

Resolution: duplicate
Status: newclosed

comment:3 Changed 8 months ago by Antoine Martin

Description: modified (diff)

Not sure why you closed as duplicate, there was no reason for UDP to be excluded from the upnp code: r28018 fixes that.

It should work (just not with the router I am using today):

xpra start --start=xterm --bind-udp=0.0.0.0:10000,auth=allow,upnp=on --no-daemon -d udp,upnp
udp read thread loop starting
upnp_add('udp', ('0.0.0.0', 10000), {'auth': 'allow', 'upnp': 'on'})
upnp=<upnpy.upnp.UPnP.UPnP object at 0x7f3ea6148b50>
pnp_add(('0.0.0.0', 10000), {'auth': 'allow', 'nodelay': '1', 'upnp': 'on'})
...
Error: cannot add UPnP port mapping
 No IGD found.

Perhaps I found a bug

Indeed!
Fixed in r28019.

comment:4 Changed 6 months ago by migration script

this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/2953

Note: See TracTickets for help on using tickets.