upnp_add on udp never called

[brief]

While investigating #2125, I found that upnp_add in socket_util.py is not added to upnp_cleanup since the contained method returns early on udp.

I otherwise discovered the message "#TODO: just like add_listen_socket above, this needs refactoring" in _new_connection and I gave it a shot: refactor_listenSocket.patch.

Perhaps I found a bug: should "self.sockets.update(local_sockets)" in network_listener:57 be called only if opts.bind? If so, an indent is missing.

[Antoine Martin]

Not sure why you closed as duplicate, there was no reason for UDP to be excluded from the upnp code: r28018 fixes that.

It should work (just not with the router I am using today):

xpra start --start=xterm --bind-udp=0.0.0.0:10000,auth=allow,upnp=on --no-daemon -d udp,upnp

udp read thread loop starting
upnp_add('udp', ('0.0.0.0', 10000), {'auth': 'allow', 'upnp': 'on'})
upnp=<upnpy.upnp.UPnP.UPnP object at 0x7f3ea6148b50>
pnp_add(('0.0.0.0', 10000), {'auth': 'allow', 'nodelay': '1', 'upnp': 'on'})
...
Error: cannot add UPnP port mapping
 No IGD found.

---

Perhaps I found a bug

Indeed!
Fixed in r28019.

[migration script]

this ticket has been moved to: ​https://github.com/Xpra-org/xpra/issues/2953