xpra icon
Bug tracker and wiki

This bug tracker and wiki are being discontinued
please use https://github.com/Xpra-org/xpra instead.


Opened 8 months ago

Last modified 6 months ago

#2954 assigned defect

upnp_add on udp never called

Reported by: brief Owned by: Antoine Martin
Priority: minor Milestone: 4.2
Component: server Version: trunk
Keywords: Cc:

Description

While investigating #2125, I found that upnp_add in socket_util.py is not added to upnp_cleanup since the contained method returns early on udp.

I otherwise discovered the message "#TODO: just like add_listen_socket above, this needs refactoring" in _new_connection and I gave it a shot: refactor_listenSocket.patch.

Perhaps I found a bug: should "self.sockets.update(local_sockets)" in network_listener:57 be called only if opts.bind? If so, an indent is missing.

Attachments (1)

refactor_listenSocket.patch​ (27.1 KB) - added by brief 8 months ago.

Download all attachments as: .zip

Change History (4)

comment:1 Changed 8 months ago by brief

Component: android → server
Priority: major → minor
Version: 3.0.x → trunk

Changed 8 months ago by brief

Attachment: refactor_listenSocket.patch​ added

comment:2 Changed 7 months ago by Antoine Martin

Milestone: 4.1 → 4.2
Status: new → assigned

Patch looks good, but too late for 4.1 as this can break things.

comment:3 Changed 6 months ago by migration script

this ticket has been moved to: ​https://github.com/Xpra-org/xpra/issues/2954

Note: See TracTickets for help on using tickets.