Opened 3 months ago
Last modified 5 weeks ago
#2954 assigned defect
upnp_add on udp never called
Reported by: | brief | Owned by: | Antoine Martin |
---|---|---|---|
Priority: | minor | Milestone: | 4.2 |
Component: | server | Version: | trunk |
Keywords: | Cc: |
Description
While investigating #2125, I found that upnp_add in socket_util.py is not added to upnp_cleanup since the contained method returns early on udp.
I otherwise discovered the message "#TODO: just like add_listen_socket above, this needs refactoring" in _new_connection and I gave it a shot: refactor_listenSocket.patch.
Perhaps I found a bug: should "self.sockets.update(local_sockets)" in network_listener:57 be called only if opts.bind? If so, an indent is missing.
Attachments (1)
Change History (4)
comment:1 Changed 3 months ago by
Component: | android → server |
---|---|
Priority: | major → minor |
Version: | 3.0.x → trunk |
Changed 3 months ago by
Attachment: | refactor_listenSocket.patch added |
---|
comment:2 Changed 2 months ago by
Milestone: | 4.1 → 4.2 |
---|---|
Status: | new → assigned |
comment:3 Changed 5 weeks ago by
this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/2954
Note: See
TracTickets for help on using
tickets.
Patch looks good, but too late for 4.1 as this can break things.