Opened 2 months ago
Last modified 6 weeks ago
#2993 assigned defect
HTML5 file upload fails on xpra 4.1-r28292
Reported by: | Florian Feldhaus | Owned by: | Antoine Martin |
---|---|---|---|
Priority: | critical | Milestone: | 4.1 |
Component: | html5 | Version: | trunk |
Keywords: | Cc: |
Description
I regularly use file uploads with my wireshark docker image which is using xpra (https://github.com/ffeldhaus/docker-wireshark). With the current stable xpra version 4.0.6-r28284 on Ubuntu 20.04, I can upload files normally. With the latest xpra beta 4.1-r28292 I get this error when uploading files via the HTML5 client:
2021-01-04 22:15:27,670 client 1 file: 8m , type: , size: 8388608 2021-01-04 22:15:31,447 Error: invalid data size for file '8m' 2021-01-04 22:15:31,448 received 12581964 bytes, expected 8388608 bytes
The xpra config files and setup are the same, but I use Ubuntu 20.04.1 LTS for running xpra stable and Ubuntu 20.10 to run xpra beta.
Change History (6)
comment:1 Changed 2 months ago by
Component: | android → html5 |
---|---|
Milestone: | 4.2 → 4.1 |
comment:2 Changed 2 months ago by
Version: | 3.0.x → 4.0.x |
---|
comment:3 Changed 2 months ago by
Version: | 4.0.x → trunk |
---|
comment:4 Changed 2 months ago by
Priority: | major → critical |
---|---|
Status: | new → assigned |
comment:5 Changed 2 months ago by
The problem is client side: 4.1 servers handle file uploads fine, but not with the latest HTML5 client.
Bisecting:
- r28000 bad
- r27000 bad
- r26000 OK
- r26500 OK
- r26750 OK
- r26875 bad
- r26812 bad
- r26781 OK
- r26796 bad
- r26788 OK
- r26792 bad
So the problem comes from the rencode packet encoder: #2018.
The easy fix would be to disable it completely.. but I'd rather fix it properly instead.
comment:6 Changed 6 weeks ago by
this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/2993
I can reproduce.