xpra icon
Bug tracker and wiki

Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#392 closed enhancement (fixed)

integrate a win32 crash report tool

Reported by: Antoine Martin Owned by: Antoine Martin
Priority: major Milestone: 0.14
Component: client Version:
Keywords: Cc:

Description

On Linux, we can more easily get gdb backtraces, even from users - see debugging with gdb.
But on win32, by the time we get a user report about a crash, all we are likely to hear is "it crashed, dr watson came up".

We ought to be able to do better than that. Maybe using:

For a start, we can collect more data. The log file basic would be a start.

Attachments (2)

win32-invalid-quality-error.png (62.6 KB) - added by Antoine Martin 4 years ago.
shows the alert box for a command line parsing error on the "quality" option
win32-encoding-help.png (92.7 KB) - added by Antoine Martin 4 years ago.
shows an alert box with some help text for a "help" command line option

Download all attachments as: .zip

Change History (9)

comment:1 Changed 5 years ago by Antoine Martin

Milestone: 0.110.12
Owner: changed from Antoine Martin to Antoine Martin
Status: newassigned

too late for 0.11

comment:2 Changed 5 years ago by Antoine Martin

Milestone: 0.12future

I think that the win32 client has been very stable, which means this is a less of a priority.

Changed 4 years ago by Antoine Martin

shows the alert box for a command line parsing error on the "quality" option

Changed 4 years ago by Antoine Martin

Attachment: win32-encoding-help.png added

shows an alert box with some help text for a "help" command line option

comment:3 Changed 4 years ago by Antoine Martin

As of r7100, we now have a catch-all alert box shown on win32 when the client exits because of an error. (this can be disabled by setting XPRA_MESSAGEBOX=0)

This does not apply to things like network disconnections which still use a non-zero exit code, this is only for bugs or other serious and unexpected problems.

Some examples:

shows an alert box with some help text for a "help" command line option

shows the alert box for a command line parsing error on the "quality" option

Last edited 4 years ago by Antoine Martin (previous) (diff)

comment:4 Changed 4 years ago by Antoine Martin

Milestone: future0.15

I haven't seen any hard crashes (the useless dr watson) for a very long time.
So I don't think we need a crash handler.

What we could do however is:

  • fire the bug report tool when we return to the launcher with an error
  • allow the launcher to inject a buffer into the logging so that we can capture the client output and include it in bug reports
  • maybe even always intercept error and warn level logging for bug reports?
  • add the ability to more easily turn debugging on for certain things from the launcher

comment:5 Changed 4 years ago by Antoine Martin

related: #752

comment:6 Changed 4 years ago by Antoine Martin

Resolution: fixed
Status: assignedclosed

Now that we have remote logging (see #786), I think this is good enough. (bar #637)

comment:7 Changed 4 years ago by Antoine Martin

Milestone: 0.150.14

(update to correct milestone)

Note: See TracTickets for help on using tickets.