xpra icon
Bug tracker and wiki

This bug tracker and wiki are being discontinued
please use https://github.com/Xpra-org/xpra instead.


Changes between Initial Version and Version 1 of Ticket #393


Ignore:
Timestamp:
07/19/13 06:08:32 (8 years ago)
Author:
Antoine Martin
Comment:

Thanks, applied in r3879

We'll need more changes before the release though, because as it is libwebp.so.2 prevents the whole module from loading because of the missing lossless functions.

We need to fail more gracefully since we already handle the case where they are not available python side (but maybe also improve how we detect if they are missing too).

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #393

    • Property Priority changed from minor to critical
    • Property Status changed from new to assigned
    • Property Milestone changed from to 0.10
  • Ticket #393 – Description

    initial v1  
    33Default libwebp library was libwebp.so.2.0.0 on my system.  With version 0.10 (r3878) of the xpra server, this result in undefined symbols:
    44
     5{{{
    56alex@net-mobile:~/xpra-src/Xpra/trunk/src$ xpra
    67cannot load webp encoder: EncodeRGB missing from xpra.codecs.webm.encode: /usr/lib/i386-linux-gnu/libwebp.so.2: undefined symbol: WebPEncodeLosslessRGB
     
    910cannot load webp encoder: EncodeBGRA missing from xpra.codecs.webm.encode: /usr/lib/i386-linux-gnu/libwebp.so.2: undefined symbol: WebPEncodeLosslessRGB
    1011<snip..>
     12}}}
    1113
    1214After updating to libwebp.so.4.0.3, libwebp.so.2.0.0 was still used, since "xpra/codecs/webm/__init__.py" tries to load .2 first, then .4:
    13 
     15{{{
    1416_LIBRARY_NAMES = ["libwebp.so.2", "libwebp.so.4"]
    15 
     17}}}
    1618Short of checking for this specifically, I would suggest favoring newer versions first in cases where multiple versions of the library is installed (patch attached)