#416 closed enhancement (fixed)
pixbuf_new_from_data or cairo take un-premultiplied rgb data
Reported by: | Antoine Martin | Owned by: | Antoine Martin |
---|---|---|---|
Priority: | major | Milestone: | 0.11 |
Component: | client | Version: | |
Keywords: | Cc: |
Description
r4151 does this, but it's slow and ugly.
Do this in-place properly, or at least return a string we can use directly.
Attachments (1)
Change History (4)
Changed 7 years ago by
Attachment: | mmap-argb-in-place.patch added |
---|
comment:1 Changed 7 years ago by
Owner: | changed from Antoine Martin to Antoine Martin |
---|---|
Status: | new → assigned |
The problem is that:
- we can get a string as data (from all encoders that can output with alpha: rgb, png, webp) or a
class 'xpra.net.mmap_pipe.c_char_Array_409600'
with mmap. A string cannot be used as writeable buffer but thec_char_Array
can. - the data we pass to
pixbuf_new_from_data()
must be string or read-only buffer, not bytearray
The patch above skips the conversions for the mmap codepath, but we need something that also addresses the double-copy from the standard codepath.
comment:2 Changed 7 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
comment:3 Changed 6 weeks ago by
this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/416
Note: See
TracTickets for help on using
tickets.
remove unnecessary conversions with mmap codepath only