#486 closed enhancement (fixed)
better xpra info namespace
Reported by: | Antoine Martin | Owned by: | alas |
---|---|---|---|
Priority: | major | Milestone: | 0.17 |
Component: | core | Version: | |
Keywords: | Cc: |
Description
Despite many changes to the namespace code: r4752, r3914, r3883, r3825, r3739, r3689, r3684, r3680, r3674, etc..
This is still wrong and stoopid. The data should be structured in nested dictionaries and we should let the client flatten it when printing it out.
ie:
window[1].encoding.speed.90p=65 window[1].encoding.speed.cur=50 ...
should be sent as:
windows : { 1 : { "encoding" : { "speed" : { "90p" : 65, "cur" : 50, } } } }
Which makes much more sense than building strings client-side for looking up the data we want!
Attachments (3)
Change History (14)
comment:1 Changed 8 years ago by
Owner: | changed from Antoine Martin to Antoine Martin |
---|---|
Status: | new → assigned |
comment:2 Changed 8 years ago by
Milestone: | 0.12 → future |
---|
comment:3 Changed 6 years ago by
Milestone: | future → 0.17 |
---|
Let's expose the new info via the dbus interface (#904), so we can generate the data in a more structured format and flatten it for the old interface.
The new interface can also include a subsystem filter, and a regex filter so we can avoid sending too much stuff.
comment:4 Changed 6 years ago by
This should be taken advantage of to reduce the cost of the info packets we send when the session statistics dialog is shown.
The packet should also be compressed and then sent from the worker thread rather than UI and network threads. It could also be compressed much more from the worker - though this should be moot if we have filtered enough.
comment:5 Changed 6 years ago by
comment:6 Changed 6 years ago by
Mostly done in r12183. See commit message.
(xpra info performance fixes backported in r12185 + r12186)
The xpra info client can now also be used to print the structured data without flattening it:
XPRA_FLATTEN_INFO=0 xpra info
The code is now much faster and cleaner. In terms of user visible changes, there should not be any (bar cosmetic ones in xpra info output).
Things left to verify / fix:
- session info, ie: fix encoding speed and quality not shown
- test bug report tool
- av-sync (verify the queue levels are still being passed through)
- test proxy server?
- command line tools output
comment:7 Changed 6 years ago by
More conversion and fixes: r12224 (gtk info), r12206 (net caps), r12189 (fix child reaper and test), r12261 (misc), r12262 (session info), r12265 + r12266 + r12267 (related refactoring)
As of r12264:
XPRA_FLATTEN_INFO=1 xpra info
or justxpra info
prints the info data (almost) the same as beforeXPRA_FLATTEN_INFO=0 xpra info
prints the data in a dense python structure format (useful for loading up into an interpreter for example)XPRA_FLATTEN_INFO=2 xpra info
will print a more user-friendly format (indented)
comment:8 Changed 6 years ago by
Owner: | changed from Antoine Martin to alas |
---|---|
Status: | assigned → new |
I have verified everything except the proxy server.
@afarr: mostly a FYI, feel free to close. (will follow up in #1154)
comment:10 Changed 6 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
This notification is here to notify you that this has been noticed.
Closing.
The flatten info flag definitely produces a drastically different output.
comment:11 Changed 16 months ago by
this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/486
A good idea, but difficult to implement. Re-scheduling.