xpra icon
Bug tracker and wiki

Opened 5 years ago

Last modified 2 months ago

#56 accepted enhancement

add new resolutions to Xdummy on the fly - dummy driver needs randr support added?

Reported by: Antoine Martin Owned by: Antoine Martin
Priority: critical Milestone: future
Component: platforms Version:
Keywords: dummy x11 Cc: thomas@…

Description

Instead of finding the nearest match, we should just add the modeline, assign it to the output then select it.
This would allow us to match the client's screen size exactly.

(somewhat blocked by #10)

Attachments (9)

add-screen-size.patch (9.5 KB) - added by Antoine Martin 5 years ago.
this patch would add a new mode to Xdummy so we can use it... but does not work
_add-screen-size.patch (9.5 KB) - added by onlyjob 5 years ago.
refreshed patch to apply over 0.6.1
1001-remove-pointless-functions.patch (2.9 KB) - added by Antoine Martin 19 months ago.
dummy randr 1.2: patch 1 Remove pointless empty functions
1002-delete-xv-stuff.patch (1.9 KB) - added by Antoine Martin 19 months ago.
dummy randr 1.2: patch 2 Delete XV stuff
1003-delete-screensaver.patch (1.0 KB) - added by Antoine Martin 19 months ago.
dummy randr 1.2: patch 3 Delete dPtr->screenSaver
1004-remove-dga.patch (7.4 KB) - added by Antoine Martin 19 months ago.
dummy randr 1.2: patch 4 Remove DGA support
1005-remove-fbbase.patch (2.5 KB) - added by Antoine Martin 19 months ago.
dummy randr 1.2: patch 5 Get rid of dPtr->FBBase
1006-randr12.patch (7.8 KB) - added by Antoine Martin 19 months ago.
dummy randr 1.2: patch 6 Support RandR 1.2
dummy-remove-functions.patch (3.5 KB) - added by Antoine Martin 6 months ago.
for testing the latest upstream patches for dummy

Download all attachments as: .zip

Change History (32)

Changed 5 years ago by Antoine Martin

Attachment: add-screen-size.patch added

this patch would add a new mode to Xdummy so we can use it... but does not work

comment:1 Changed 5 years ago by Antoine Martin

Owner: changed from Antoine Martin to Antoine Martin
Status: newaccepted
Summary: add new resolutions to Xdummy on the flyadd new resolutions to Xdummy on the fly - dummy driver needs randr support added?

After asking xorg-devel, it would seem that the dummy driver does not support randr - or at least not fully.

The patch above attempts to replicate xrandr's command line functionality and even includes its own modeline calculator, so from xpra's side it is pretty much ready.

comment:2 Changed 5 years ago by Antoine Martin

Component: androidplatforms
Milestone: 0.0.7.x0.2

comment:3 Changed 5 years ago by Antoine Martin

Milestone: 0.2future

Not heard back, and less critical now that the default config contains many of the typical resolutions found on desktops and even android devices.

Changed 5 years ago by onlyjob

Attachment: _add-screen-size.patch added

refreshed patch to apply over 0.6.1

comment:4 Changed 4 years ago by Antoine Martin

Closed #186 (duplicate - some info there)

comment:5 Changed 4 years ago by Thomas Koch

Cc: thomas@… added

comment:7 Changed 3 years ago by Antoine Martin

Forgot to update this ticket:

comment:8 Changed 2 years ago by Antoine Martin

Milestone: future0.15

Nicolas Boichat has just posted X11 patches to do exactly this!: PATCH dummy: Add support for custom resolutions (RandR 1.2)

Maybe this will fix #728
We'll just have to ensure this works with DPI (#163) - that we deal with #732 if possible, see also #349

Last edited 2 years ago by Antoine Martin (previous) (diff)

comment:9 Changed 2 years ago by Antoine Martin

Milestone: 0.150.16

Looks like the discussion of what to do for randr 1.2 support is ongoing: Cleanups and RandR 1.2 support, with different implementations suggested.

And so this will have to wait until this gets merged in one form or another, and maybe we only have to package it then which would be great (assuming that the new code can be built against older servers that is...)

comment:11 Changed 22 months ago by Antoine Martin

Re-post: xvfb: add randr support (v2)

I think we should update the dummy driver with the same changes.

comment:12 Changed 22 months ago by Antoine Martin

In one of the responses to the patch above: http://lists.x.org/archives/xorg-devel/2015-June/046666.html links to: PATCH xf86-video-dummy 0/6: Cleanups and RandR 1.2 support - which is a better approach IMO.

Last edited 22 months ago by Antoine Martin (previous) (diff)

comment:13 Changed 19 months ago by Antoine Martin

See also #969, in particular the ramdac fix in ticket:969#comment:3

Changed 19 months ago by Antoine Martin

dummy randr 1.2: patch 1 Remove pointless empty functions

Changed 19 months ago by Antoine Martin

Attachment: 1002-delete-xv-stuff.patch added

dummy randr 1.2: patch 2 Delete XV stuff

Changed 19 months ago by Antoine Martin

dummy randr 1.2: patch 3 Delete dPtr->screenSaver

Changed 19 months ago by Antoine Martin

Attachment: 1004-remove-dga.patch added

dummy randr 1.2: patch 4 Remove DGA support

Changed 19 months ago by Antoine Martin

Attachment: 1005-remove-fbbase.patch added

dummy randr 1.2: patch 5 Get rid of dPtr->FBBase

Changed 19 months ago by Antoine Martin

Attachment: 1006-randr12.patch added

dummy randr 1.2: patch 6 Support RandR 1.2

comment:14 Changed 19 months ago by Antoine Martin

just tried the patch series above and hit a snag: my xorg-devel reply

comment:15 Changed 18 months ago by Antoine Martin

See also: MST monitors and the proposal for RandR 1.5 which would have the concept of "monitors" (without requiring us to have virtual CRTCs attached to them apparently)

comment:16 Changed 17 months ago by Antoine Martin

Keywords: dummy x11 added
Milestone: 0.161.0
Priority: majorcritical

No movement on this upstream, re-scheduling.

comment:17 Changed 16 months ago by Antoine Martin

Milestone: 1.00.17

The randr v2 patch has been merged: http://lists.x.org/archives/xorg-devel/2015-December/048228.html.
Commit: 3d68d1f26709ecb5ce22a9baa0d3d8162574ed6a.
So either we figure out how to use the same code in Xdummy, or we switch back to Xvfb with newer versions?
Will have to test this new stuff: re-scheduling.

comment:18 Changed 12 months ago by Antoine Martin

Milestone: 0.170.18

re-scheduling

comment:19 Changed 9 months ago by Antoine Martin

We're not alone in needing this: xf86-video-dummy: resize to exact resolution from Chrome Remote Desktop developer Erik Jensen.

comment:20 Changed 9 months ago by Antoine Martin

Milestone: 0.181.0

Milestone renamed

comment:21 Changed 8 months ago by Antoine Martin

Milestone: 1.0future

I don't have time for this, new links:

Changed 6 months ago by Antoine Martin

for testing the latest upstream patches for dummy

comment:22 Changed 6 months ago by Antoine Martin

Recent discussion: remove dead code in dummy driver: In 2014 I had also modified the dummy driver while working with Teradici Corporation to support not only arbitrary pixel dimensions, but also multiple monitors. The latter feature might not make sense to some folks, but if you have a server-side Xserver mapped to a hardware thin client sitting across a network, which has multiple physical monitors attached, you want the Xserver to be configured in the exact same manner as the tin client. Even though there is just a virtual framebuffer in main memory, X applications need to know the number/size/location of monitors so that toolbars are placed properly, windows are fullscreen'ed properly, etc. And when the user moves from one hardware thin client to another, which may have a different monitor configuration, the Xserver session needs to change to that configuration.

comment:23 Changed 2 months ago by Antoine Martin

This will also make #1008 redundant.

Note: See TracTickets for help on using tickets.