xpra icon
Bug tracker and wiki

Opened 6 years ago

Closed 6 years ago

#603 closed defect (fixed)

build_info.py missing when setup.py install is passed --skip-build

Reported by: pyther Owned by: pyther
Priority: major Milestone: 0.14
Component: core Version: 0.13.x
Keywords: Cc:

Description

Build Procedure

$ python setup.py clean
$ python setup.py build
$ python setup.py install --prefix /usr --root /tmp/test --skip-build

$ ls /tmp/test/usr/lib64/python2.6/site-packages/xpra/build_info.py
ls: cannot access /tmp/test/usr/lib64/python2.6/site-packages/xpra/build_info.py: No such file or directory
$ python setup.py clean
$ python setup.py build
$ python setup.py install --prefix /usr --root /tmp/test

$ ls /tmp/test/usr/lib64/python2.6/site-packages/xpra/build_info.py
/tmp/test/usr/lib64/python2.6/site-packages/xpra/build_info.py

difference in file listings

$ diff /tmp/xpra-skip-build.txt /tmp/xpra.txt 
15a16,17
> /tmp/test/usr/lib64/python2.6/site-packages/xpra/build_info.py
> /tmp/test/usr/lib64/python2.6/site-packages/xpra/build_info.pyc

Change History (4)

comment:1 Changed 6 years ago by Antoine Martin

Maybe we can re-use the code from ticket:172#comment:37 for this.

comment:2 Changed 6 years ago by pyther

On lines 344 - 347 add_modules is being called

add_modules("xpra",
            "xpra.platform",
            "xpra.codecs",
            "xpra.codecs.xor")

add_module adds any *.py file that is in the xpra module directory. This includes things like xpra.src_info and xpra.build_info.

xpra/src_info.py and xpra/build_info.py don't get generated until lines 791-803. Therefore, when add_module(xpra) get called, the src_info.py and build_info.py don't exist, thus they don't get included.

I see two potential fixes:

  • generate build_info.py and src_info.py before calling add_module(xpra)
  • ship dummy build_info.py and src_info.py files, perhaps all values in the dummy file should be 'unknown'

I think solution 2 makes more sense, because the xpra code base tries to load values from these files and if they don't exist, errors get thrown.

Last edited 6 years ago by Antoine Martin (previous) (diff)

comment:3 Changed 6 years ago by Antoine Martin

Owner: changed from Antoine Martin to pyther

r6919 works for me, can you confirm?

(I should backport this to v0.13.x)

comment:4 Changed 6 years ago by Antoine Martin

Resolution: fixed
Status: newclosed

Not heard back, closing. Shout if I'm wrong.

Note: See TracTickets for help on using tickets.