client remains running on server upgrade (on shared SSH connection)

[onlyjob]

On 0.14.0 when I upgraded server (e.g. xpra upgrade :44) attached client closed all its windows and logged "server is not responding, drawing spinners over the windows" but remains running...

It seems to happen when SSH connection do not terminate which can be the case with the following settings in ~/.ssh/config:

host *
    controlmaster auto
    controlpath ~/.ssh/__tmp-ssh-%r@%h:%p

To reproduce with the above SSH config:

• start server on remote host
• disconnect
• xpra attach ssh:remotehost:44
• ssh remotehost
• xpra upgrade :44

I did not see this behaviour before 0.14.0...

[Antoine Martin]

I cannot reproduce. Are you sure about your instructions?
The wording attached client closed all its windows and logged.. is confusing.

Are you aware of the --exit-ssh and --no-exit-ssh options?

[onlyjob]

Replying to totaam:

I cannot reproduce. Are you sure about your instructions?

Pretty sure, I even tried commenting relevant section of SSH config...

The wording attached client closed all its windows and logged.. is confusing.

Sorry. I meant to say that all windows disappeared but Xpra icon were still in tray while "server is not responding, drawing spinners over the windows" appeared in console...

Are you aware of the --exit-ssh and --no-exit-ssh options?

Had no idea, became aware just now thanks.

[Antoine Martin]

(editing bug title and version only)

[Antoine Martin]

Recommended reading: #380.
Explains why the switch exists.

When you run "xpra upgrade", the client should get disconnected and if you have exit-ssh on, so will your other ssh session.

But, maybe this is another case of #581 / #659? (server not sending disconnect as it should).

[Antoine Martin]

Not heard back, closing.