lossy regions with "Raw RGB" encoding

[onlyjob]

Just noticed that on 0.14.1 some windows' regions are lossy when "Raw RGB" encoding is chosen... I've spotted this on text on red background in Libreoffice Calc. PNG encodings seems to be OK as well as loseless WebP.

[Antoine Martin]

I'm glad you use rgb as encoding as you tend to hit bugs that are only possible with rgb encoding and that we missed because of that.

The problem here is that rgb is a virtual encoding, and depending on whether the window has any alpha and whether the client can actually show the alpha, we choose between rgb24 and rgb32. The checks wrongly decided that rgb was not supported as an encoding.. (because it isn't!) and used something else (dynamically chosen). Fixed in r7384. Will backport.

You can easily verify what gets used with (for "selection=" you need r7385 which is in 0.14.x for the next release):

xpra info | egrep "frame|encoding=|selection=|last_used="

Last note: this was caused by changes that made encoding selection a lot faster.

[onlyjob]

Replying to totaam:

I'm glad you use rgb as encoding as you tend to hit bugs that are only possible with rgb encoding and that we missed because of that.

The pleasure is mine. :)

Fixed in r7384. Will backport.

Tested and confirmed as fixed. Thank you.

[Antoine Martin]

Backport in r7387. Closing.

[migration script]

this ticket has been moved to: ​https://github.com/Xpra-org/xpra/issues/652