#652 closed defect (fixed)
lossy regions with "Raw RGB" encoding
Reported by: | onlyjob | Owned by: | Antoine Martin |
---|---|---|---|
Priority: | major | Milestone: | |
Component: | encodings | Version: | 0.14.x |
Keywords: | Cc: |
Description
Just noticed that on 0.14.1 some windows' regions are lossy when "Raw RGB" encoding is chosen... I've spotted this on text on red background in Libreoffice Calc. PNG encodings seems to be OK as well as loseless WebP.
Change History (4)
comment:2 Changed 6 years ago by
comment:3 Changed 6 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
Backport in r7387. Closing.
comment:4 Changed 5 days ago by
this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/652
Note: See
TracTickets for help on using
tickets.
I'm glad you use rgb as encoding as you tend to hit bugs that are only possible with rgb encoding and that we missed because of that.
The problem here is that
rgb
is a virtual encoding, and depending on whether the window has any alpha and whether the client can actually show the alpha, we choose betweenrgb24
andrgb32
. The checks wrongly decided thatrgb
was not supported as an encoding.. (because it isn't!) and used something else (dynamically chosen). Fixed in r7384. Will backport.You can easily verify what gets used with (for "selection=" you need r7385 which is in 0.14.x for the next release):
Last note: this was caused by changes that made encoding selection a lot faster.