xpra does not correctly parse IPv6 addresses

[Ionic]

Giving xpra any IPv6 address to connect to, it fails connecting due to wrong parsing.

Note that this usage is indeed illegal, as it does not specify the address in square brackets, required when allowing abbreviated addresses (with ::):

xpra attach ssh:ionic@2a01:4f8:d16:601:20e:8eff:fe31:5cda:99

xpra initialization error: ('invalid ssh port specified: %s', '4f8:d16:601:20e:8eff:fe31:5cda')

But this should work just fine:

xpra attach ssh:ionic@[2a01:4f8:d16:601:20e:8eff:fe31:5cda]:99

xpra initialization error: ('invalid ssh port specified: %s', '4f8:d16:601:20e:8eff:fe31:5cda]')

Also make sure to please test link-local addresses, like fe80::21b:21ff:fe2a:c4fe%en1 (personal example only, will not work on your machine.)

[Antoine Martin]

This should be fixed in r7874.
Please let me know so I can apply to v0.14.x.

Note: I think it is preferable to use this syntax for ipv6 addresses, because it is more clear and also allows you to specify the ssh port number:

xpra attach ssh/USERNAME@[fe80::XXXX:XXXX:XXXX:XXXX%enp2s4]:SSH_PORT/DISPLAY_NO

[Antoine Martin]

Backport for v0.14.x in r7896.

[Ionic]

Thanks, seems to be working fine with 0.14.9.

Closing.

[Antoine Martin]

Follow up: #1594

[migration script]

this ticket has been moved to: ​https://github.com/Xpra-org/xpra/issues/704