Xpra: Ticket #822: shadow does not work with 0.14.20

With xpra 0.14.20 the shadow mode results in:

2015-03-11 20:43:16,449 server error processing new connection from Protocol(SocketConnection(/home/rvm/.xpra/ultra48-101-0)): calculate_workarea() takes exactly 1 argument (3 given)
Traceback (most recent call last):
  File "/RVM/lib/xpra/lib/python/xpra/server/server_core.py", line 462, in call_hello_oked
    self.hello_oked(proto, packet, c, auth_caps)
  File "/RVM/lib/xpra/lib/python/xpra/server/server_base.py", line 592, in hello_oked
    self.calculate_workarea(w, h)
TypeError: calculate_workarea() takes exactly 1 argument (3 given)

The attached patch seems to fix it for me. At least "xpra shadow" starts again. I don't know if more is needed.



Thu, 12 Mar 2015 02:27:45 GMT - floemker: attachment set


Sat, 14 Mar 2015 03:39:23 GMT - Antoine Martin: status, description changed; resolution, milestone set

Well, that's embarrassing, we should have caught that sooner! (added to #660)

Fix applied in r8777. Thanks! (Even though this is am important fix, I may wait a few more days before releasing 0.14.21 because this is the only fix queued up so far..)


Sat, 23 Jan 2021 05:07:03 GMT - migration script:

this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/822