xpra icon
Bug tracker and wiki

This bug tracker and wiki are being discontinued
please use https://github.com/Xpra-org/xpra instead.


Changes between Initial Version and Version 2 of Ticket #923


Ignore:
Timestamp:
11/16/15 15:48:19 (5 years ago)
Author:
Antoine Martin
Comment:

Sorry for the long delay in dealing with this bug and thank you for the detailed bug report. This has uncovered a serious bug which has been there for many years and may have had all sorts of undesirable side effects.

The trivial server side fix is in r11247, and it will be included in the next stable update.

And since I was there, I improved the code a bit more:

  • r11248 makes the code easier to read
  • r11249 should workaround any bugs by using the "big hammer": a full keyboard reset
  • r11250 is a better way of choosing a modifier key to unpress (may also backport this one)
  • r11254 only loops over modifiers lists if they are actually different, after' removing the ones we don't care about

Thought: maybe we should keep track of which modifier keycodes are used? (at the moment, when we need to add a modifier, we pick the first keycode that matches)

@fladnag: please close when you have time to confirm that this is fixed (will make new beta builds soon)

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #923

    • Property Owner changed from Antoine Martin to fladnag

  • Ticket #923 – Description

    initial v2  
    1 --- environment ---
    2 server : debian 8, xpra 0.14.10
    3 client : win 7, xpra 0.14.24, from winswitch, but using only xpra_cmd.exe
     1Environment
     2* server : debian 8, xpra 0.14.10
     3* client : win 7, xpra 0.14.24, from winswitch, but using only xpra_cmd.exe
    44
    5 keyboard : fr - default
     5Keyboard : fr - default
    66
    7 --- logs ---
    8 in logs, SERVER and USER have been replaced for security reasons ^^
     7Logs: SERVER and USER have been replaced for security reasons
    98
    10 --- actions ---
     9{{{
    1110xpra start :100 -d keyboard
    1211DISPLAY=:100 xterm &
     12}}}
     13{{{
     14xpra attach ssh:...:100 -d keyboard
     15}}}
    1316
    14 xpra attach ssh:...:100 -d keyboard
    15 
    16 focus xterm
    17 # (altgr 3) : OK
    18 Ctrl-Escape (open windows menu)
    19 Escape (close windows menu)
    20 # (altgr 3) : OK
    21 Ctrl-Escape
    22 Escape
    23 click on xterm windows
    24 # (altgr 3) : KO, display "£" instead
    25 backspace : KO, display "ÿ" instead
     17Steps:
     18* focus xterm
     19* press {{{AltGr}} + {{{3}}} : OK, shows "#"
     20* press {{{Ctrl}}} + {{{Escape}}}: opens windows start menu
     21* press {{{Escape}}}: closes start menu
     22* press {{{AltGr}} + {{{3}}} : OK, shows "#"
     23* press {{{Ctrl}}} + {{{Escape}}}: opens windows start menu
     24* press {{{Escape}}}: closes start menu
     25* click on xterm window
     26* press {{{AltGr}} + {{{3}}} : bug, prints "£" instead of "#"
     27* press {{{Backspace}}} : bug, prints "ÿ" instead